From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYuoo-0005pE-Ra for qemu-devel@nongnu.org; Thu, 15 Nov 2012 03:29:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYuol-00078E-Ph for qemu-devel@nongnu.org; Thu, 15 Nov 2012 03:29:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:31910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYuol-00077W-HS for qemu-devel@nongnu.org; Thu, 15 Nov 2012 03:28:59 -0500 Message-ID: <50A4A7C8.8010904@redhat.com> Date: Thu, 15 Nov 2012 09:28:56 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <50A4A682.2010508@siemens.com> In-Reply-To: <50A4A682.2010508@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On 11/15/12 09:23, Jan Kiszka wrote: > The Linux is more tolerant here as well: Just stop parsing the device > descriptors when an error is detected but do not reset what was found > so far. This allows to run buggy devices with partially invalid > descriptors. > -error: > - usb_ep_reset(&s->dev); > - return 1; I'd prefer to keep the error jump target to handle the parse error here. Dumping the reset there is fine with me, but I'd prefer this event being logged (trace point or stderr message or both) to ease trouble shooting in case a device doesn't behave as expected. thanks, Gerd