From: Gerd Hoffmann <kraxel@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes
Date: Thu, 15 Nov 2012 09:55:03 +0100 [thread overview]
Message-ID: <50A4ADE7.4030006@redhat.com> (raw)
In-Reply-To: <1352910105-10272-1-git-send-email-hdegoede@redhat.com>
On 11/14/12 17:21, Hans de Goede wrote:
> While working on moving usb-redir and usb-hid over to using async packet
> handling for their interrupt input endpoints. I've found and fixed quite
> a few ehci bugs.
>
> Unfortunately the moving to async for interrupt endpoints turns out to be a
> bad idea, as it causes issues for migration, an async completed packet will
> not getting written back to guest memory until the next poll time, and if a
> migration happens in between it will get lost!
Ok, so it looks like 1-3 are clear bugfixes which are needed in 1.3
I'd tend to schedule the other ones for the 1.4 devel cycle. They are
clearly nice cleanups, but as we are not going the async-for-intr route
I think they are not important enougth to push them post-freeze.
Patch 8 doesn't pass checkpatch (yes, it just shuffles around existing
code, but it's still nice to fix style issues while touching those bits).
cheers,
Gerd
next prev parent reply other threads:[~2012-11-15 8:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 16:21 [Qemu-devel] [PATCH 00/10] ehci: various fixes Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 01/10] ehci: Don't access packet after freeing it Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 02/10] ehci: Fixup q->qtdaddr after cancelling an already completed packet Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 03/10] ehci: Better detection for qtd-s linked in circles Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 04/10] ehci: Add a ehci_writeback_async_complete_packet helper function Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 05/10] ehci: Add ehci_verify_qh and ehci_verify_qtd helper functions Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 06/10] ehci: Verify guest does not change the token of inflight qtd-s Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 07/10] ehci: Don't verify the next pointer for periodic qh-s Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 08/10] ehci: Move get / put_dwords upwards Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 09/10] ehci: writeback_async_complete_packet: verify qh and qtd Hans de Goede
2012-11-14 16:21 ` [Qemu-devel] [PATCH 10/10] ehci: Verify qtd for async completed packets Hans de Goede
2012-11-15 8:55 ` Gerd Hoffmann [this message]
2012-11-15 11:58 ` [Qemu-devel] [PATCH 00/10] ehci: various fixes Hans de Goede
2012-11-15 12:06 ` Gerd Hoffmann
2012-11-15 12:11 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A4ADE7.4030006@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).