From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59291)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TYvEH-0008CL-L6
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 03:55:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TYvEE-0005ik-It
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 03:55:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44960)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1TYvEE-0005ig-Az
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 03:55:18 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAF8tCL6018852
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 15 Nov 2012 03:55:17 -0500
Message-ID: <50A4ADE7.4030006@redhat.com>
Date: Thu, 15 Nov 2012 09:55:03 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1352910105-10272-1-git-send-email-hdegoede@redhat.com>
In-Reply-To: <1352910105-10272-1-git-send-email-hdegoede@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org

On 11/14/12 17:21, Hans de Goede wrote:
> While working on moving usb-redir and usb-hid over to using async packet
> handling for their interrupt input endpoints. I've found and fixed quite
> a few ehci bugs.
> 
> Unfortunately the moving to async for interrupt endpoints turns out to be a
> bad idea, as it causes issues for migration, an async completed packet will
> not getting written back to guest memory until the next poll time, and if a
> migration happens in between it will get lost!

Ok, so it looks like 1-3 are clear bugfixes which are needed in 1.3

I'd tend to schedule the other ones for the 1.4 devel cycle.  They are
clearly nice cleanups, but as we are not going the async-for-intr route
I think they are not important enougth to push them post-freeze.

Patch 8 doesn't pass checkpatch (yes, it just shuffles around existing
code, but it's still nice to fix style issues while touching those bits).

cheers,
  Gerd