From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40786) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYvjN-0007xA-IK for qemu-devel@nongnu.org; Thu, 15 Nov 2012 04:27:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYvjK-0006Hy-GL for qemu-devel@nongnu.org; Thu, 15 Nov 2012 04:27:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYvjK-0006Hu-8m for qemu-devel@nongnu.org; Thu, 15 Nov 2012 04:27:26 -0500 Message-ID: <50A4AF2B.3020003@redhat.com> Date: Thu, 15 Nov 2012 10:00:27 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <50A4A682.2010508@siemens.com> <50A4A7C8.8010904@redhat.com> <50A4A851.5000000@siemens.com> In-Reply-To: <50A4A851.5000000@siemens.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb: host-linux: Ignore parsing errors of the device descriptors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel On 11/15/12 09:31, Jan Kiszka wrote: >> > I'd prefer to keep the error jump target to handle the parse error here. >> > Dumping the reset there is fine with me, but I'd prefer this event being >> > logged (trace point or stderr message or both) to ease trouble shooting >> > in case a device doesn't behave as expected. > That would be "over-logging" as we already record the individual > reasons. There is simply no code to jump to after the refactoring. Oh, right, we trace that already. Ok then. Patch added to usb patch queue. thanks, Gerd