From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYyDb-0004kD-It for qemu-devel@nongnu.org; Thu, 15 Nov 2012 07:06:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYyDY-0007Ar-GZ for qemu-devel@nongnu.org; Thu, 15 Nov 2012 07:06:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYyDY-0007Aj-8e for qemu-devel@nongnu.org; Thu, 15 Nov 2012 07:06:48 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAFC6lp4013702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 15 Nov 2012 07:06:47 -0500 Message-ID: <50A4DAD4.8000606@redhat.com> Date: Thu, 15 Nov 2012 13:06:44 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1352910105-10272-1-git-send-email-hdegoede@redhat.com> <50A4ADE7.4030006@redhat.com> <50A4D8D9.608@redhat.com> In-Reply-To: <50A4D8D9.608@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/10] ehci: various fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hans de Goede Cc: qemu-devel@nongnu.org On 11/15/12 12:58, Hans de Goede wrote: > Hi, > > On 11/15/2012 09:55 AM, Gerd Hoffmann wrote: >> On 11/14/12 17:21, Hans de Goede wrote: >>> While working on moving usb-redir and usb-hid over to using async packet >>> handling for their interrupt input endpoints. I've found and fixed quite >>> a few ehci bugs. >>> >>> Unfortunately the moving to async for interrupt endpoints turns out >>> to be a >>> bad idea, as it causes issues for migration, an async completed >>> packet will >>> not getting written back to guest memory until the next poll time, >>> and if a >>> migration happens in between it will get lost! >> >> Ok, so it looks like 1-3 are clear bugfixes which are needed in 1.3 >> > > Ack, I think that "ehci: Don't verify the next pointer for periodic qh-s" > belongs in 1.3 too, since this could be hit with host-redirection which > does use async completion for interrupt endpoints. > > Moving it forward in the patch-set will cause a conflict though, I'll go > and > do the reshuffle myself, throw in 2 usb-redir fixes and then send a new set > targetting 1.3. Thanks. > Do you also want a separate set on top for 1.4 / > usb-next, or > do you want me to keep the rest in my own tree for now ? Keep it in your tree for now. cheers, Gerd