* [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing
@ 2012-11-15 14:42 Peter Lieven
2012-11-15 14:55 ` ronnie sahlberg
2012-11-15 16:00 ` Paolo Bonzini
0 siblings, 2 replies; 3+ messages in thread
From: Peter Lieven @ 2012-11-15 14:42 UTC (permalink / raw)
To: qemu-devel@nongnu.org; +Cc: kwolf, ronnie sahlberg
If an invalid URL is specified iscsi_get_error(iscsi) is called
with iscsi == NULL.
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/iscsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index d0b1a10..b5c3161 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const
char *filename, int flags)
iscsi_url = iscsi_parse_full_url(iscsi, filename);
if (iscsi_url == NULL) {
- error_report("Failed to parse URL : %s %s", filename,
- iscsi_get_error(iscsi));
+ error_report("Failed to parse URL : %s", filename);
ret = -EINVAL;
goto out;
}
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing
2012-11-15 14:42 [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing Peter Lieven
@ 2012-11-15 14:55 ` ronnie sahlberg
2012-11-15 16:00 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: ronnie sahlberg @ 2012-11-15 14:55 UTC (permalink / raw)
To: Peter Lieven; +Cc: kwolf, qemu-devel@nongnu.org
Acked-By: ronniesahlberg@gmail.com
On Thu, Nov 15, 2012 at 6:42 AM, Peter Lieven <pl@dlhnet.de> wrote:
> If an invalid URL is specified iscsi_get_error(iscsi) is called
> with iscsi == NULL.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/iscsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index d0b1a10..b5c3161 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const char
> *filename, int flags)
>
> iscsi_url = iscsi_parse_full_url(iscsi, filename);
> if (iscsi_url == NULL) {
> - error_report("Failed to parse URL : %s %s", filename,
> - iscsi_get_error(iscsi));
> + error_report("Failed to parse URL : %s", filename);
> ret = -EINVAL;
> goto out;
> }
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing
2012-11-15 14:42 [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing Peter Lieven
2012-11-15 14:55 ` ronnie sahlberg
@ 2012-11-15 16:00 ` Paolo Bonzini
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Bonzini @ 2012-11-15 16:00 UTC (permalink / raw)
To: Peter Lieven; +Cc: kwolf, qemu-devel@nongnu.org, ronnie sahlberg
Il 15/11/2012 15:42, Peter Lieven ha scritto:
> If an invalid URL is specified iscsi_get_error(iscsi) is called
> with iscsi == NULL.
>
> Signed-off-by: Peter Lieven <pl@kamp.de>
Applied to scsi-next branch, but next time please disable format=flowed
if you want to send patches with Thunderbird. It mangles whitespace.
Paolo
> ---
> block/iscsi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index d0b1a10..b5c3161 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const
> char *filename, int flags)
>
> iscsi_url = iscsi_parse_full_url(iscsi, filename);
> if (iscsi_url == NULL) {
> - error_report("Failed to parse URL : %s %s", filename,
> - iscsi_get_error(iscsi));
> + error_report("Failed to parse URL : %s", filename);
> ret = -EINVAL;
> goto out;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-15 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-15 14:42 [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing Peter Lieven
2012-11-15 14:55 ` ronnie sahlberg
2012-11-15 16:00 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).