qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, Peter Lieven <pl@dlhnet.de>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login
Date: Thu, 15 Nov 2012 16:54:06 +0100	[thread overview]
Message-ID: <50A5101E.1030705@redhat.com> (raw)
In-Reply-To: <CAN05THQF5extnO0DjbMdr_YyZ9U=7Zrhm+GQ_xCoMDrO+FfOcw@mail.gmail.com>

Il 15/11/2012 15:57, ronnie sahlberg ha scritto:
> I dont know if we should switch to use synchronous code here.
> It is much nicer if all code is async.

bdrv_open is generally synchronous, so I think Peter's patch is ok.

Paolo

> Is it possible to add a timeout instead that would break out if the
> connect/login has not completed within a certain amount of time?

  parent reply	other threads:[~2012-11-15 15:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 14:50 [Qemu-devel] [PATCH] iscsi: fix deadlock during login Peter Lieven
2012-11-15 14:57 ` ronnie sahlberg
2012-11-15 15:05   ` Peter Lieven
2012-11-15 15:54   ` Paolo Bonzini [this message]
2012-11-15 16:11     ` Peter Lieven
2012-11-15 16:13     ` ronnie sahlberg
2012-11-15 16:37       ` Paolo Bonzini
2012-11-16 10:38         ` Kevin Wolf
2012-11-16 17:38           ` Peter Lieven
2012-11-16 17:55             ` Paolo Bonzini
2012-11-15 18:28     ` Peter Lieven
2012-11-16  7:44       ` Paolo Bonzini
2012-11-16  9:26         ` Peter Lieven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A5101E.1030705@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pl@dlhnet.de \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).