From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56229)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TZ1sB-0002z5-Ag
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 11:01:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TZ1s8-0001YP-8F
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 11:00:59 -0500
Received: from mail-pa0-f45.google.com ([209.85.220.45]:43212)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1TZ1s8-0001YK-0R
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 11:00:56 -0500
Received: by mail-pa0-f45.google.com with SMTP id fb10so1123048pad.4
	for <qemu-devel@nongnu.org>; Thu, 15 Nov 2012 08:00:55 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50A511B0.7090309@redhat.com>
Date: Thu, 15 Nov 2012 17:00:48 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <50A4FF3E.4010209@dlhnet.de>
In-Reply-To: <50A4FF3E.4010209@dlhnet.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] iscsi: fix segfault in url parsing
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@dlhnet.de>
Cc: kwolf@redhat.com, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, ronnie sahlberg <ronniesahlberg@gmail.com>

Il 15/11/2012 15:42, Peter Lieven ha scritto:
> If an invalid URL is specified iscsi_get_error(iscsi) is called
> with iscsi == NULL.
> 
> Signed-off-by: Peter Lieven <pl@kamp.de>

Applied to scsi-next branch, but next time please disable format=flowed
if you want to send patches with Thunderbird.  It mangles whitespace.

Paolo

> ---
>  block/iscsi.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/iscsi.c b/block/iscsi.c
> index d0b1a10..b5c3161 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const
> char *filename, int flags)
> 
>      iscsi_url = iscsi_parse_full_url(iscsi, filename);
>      if (iscsi_url == NULL) {
> -        error_report("Failed to parse URL : %s %s", filename,
> -                     iscsi_get_error(iscsi));
> +        error_report("Failed to parse URL : %s", filename);
>          ret = -EINVAL;
>          goto out;
>      }