From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40035)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZ2S8-0006w2-CN
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 11:38:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZ2S5-0004ar-AU
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 11:38:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:17678)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZ2S5-0004al-2I
	for qemu-devel@nongnu.org; Thu, 15 Nov 2012 11:38:05 -0500
Message-ID: <50A51A52.4000807@redhat.com>
Date: Thu, 15 Nov 2012 17:37:38 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <50A50150.8010201@dlhnet.de>
	<CAN05THQF5extnO0DjbMdr_YyZ9U=7Zrhm+GQ_xCoMDrO+FfOcw@mail.gmail.com>
	<50A5101E.1030705@redhat.com>
	<CAN05THSjzrNXBLqYYxM22g5x2xZFxQqh+OfZVo_OuiVZ_ygvOA@mail.gmail.com>
In-Reply-To: <CAN05THSjzrNXBLqYYxM22g5x2xZFxQqh+OfZVo_OuiVZ_ygvOA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: ronnie sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, Peter Lieven <pl@dlhnet.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Il 15/11/2012 17:13, ronnie sahlberg ha scritto:
> On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Il 15/11/2012 15:57, ronnie sahlberg ha scritto:
>>> I dont know if we should switch to use synchronous code here.
>>> It is much nicer if all code is async.
>>
>> bdrv_open is generally synchronous, so I think Peter's patch is ok.
> 
> I was thinking about the case where you disconnect/reconnect a device
> at runtime. Like swapping the medium in a CDROM.
> If bdrv_open() is synchronous and blocks for a long time, would that
> not impact the rest of QEMU?

Yes, it's not optimal, but VCPUs would still run until they request I/O.
 But usually iscsi devices should be non-removable, no?  That leaves
hotplug as the only problematic case.

Paolo

> 
> Otherwise:
> Acked-by:  ronniesahlberg@gmail.com
> 
>>
>> Paolo
>>
>>> Is it possible to add a timeout instead that would break out if the
>>> connect/login has not completed within a certain amount of time?
>>