From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51935) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZGbE-0000Ve-JP for qemu-devel@nongnu.org; Fri, 16 Nov 2012 02:44:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZGbB-0004bC-HI for qemu-devel@nongnu.org; Fri, 16 Nov 2012 02:44:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZGbB-0004ah-99 for qemu-devel@nongnu.org; Fri, 16 Nov 2012 02:44:25 -0500 Message-ID: <50A5EED1.3060503@redhat.com> Date: Fri, 16 Nov 2012 08:44:17 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <50A50150.8010201@dlhnet.de> <50A5101E.1030705@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven Cc: kwolf@redhat.com, Peter Lieven , "qemu-devel@nongnu.org" , ronnie sahlberg Il 15/11/2012 19:28, Peter Lieven ha scritto: >>> >> I dont know if we should switch to use synchronous code here. >>> >> It is much nicer if all code is async. >> > >> > bdrv_open is generally synchronous, so I think Peter's patch is ok. > if all is sync wouldn't it be best to have all code in iscsi_open sync > then and convert the iscsi_inquiry and iscsi_readcapacity commands also to > sync? Indeed, there is no real advantage in using qemu_aio_wait(). I didn't know libiscsi also had sync APIs. :) Paolo