From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZICD-0005tx-Ll for qemu-devel@nongnu.org; Fri, 16 Nov 2012 04:26:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZICA-0005YU-JT for qemu-devel@nongnu.org; Fri, 16 Nov 2012 04:26:45 -0500 Received: from ssl.dlhnet.de ([91.198.192.8]:46953 helo=ssl.dlh.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZICA-0005YO-Cd for qemu-devel@nongnu.org; Fri, 16 Nov 2012 04:26:42 -0500 Message-ID: <50A606CF.6060208@dlhnet.de> Date: Fri, 16 Nov 2012 10:26:39 +0100 From: Peter Lieven MIME-Version: 1.0 References: <50A50150.8010201@dlhnet.de> <50A5101E.1030705@redhat.com> <50A5EED1.3060503@redhat.com> In-Reply-To: <50A5EED1.3060503@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, Peter Lieven , "qemu-devel@nongnu.org" , ronnie sahlberg Am 16.11.2012 08:44, schrieb Paolo Bonzini: > Il 15/11/2012 19:28, Peter Lieven ha scritto: >>>>>> I dont know if we should switch to use synchronous code here. >>>>>> It is much nicer if all code is async. >>>> bdrv_open is generally synchronous, so I think Peter's patch is ok. >> if all is sync wouldn't it be best to have all code in iscsi_open sync >> then and convert the iscsi_inquiry and iscsi_readcapacity commands also to >> sync? > Indeed, there is no real advantage in using qemu_aio_wait(). I didn't > know libiscsi also had sync APIs. :) ok, give me some days to rewrite this patch. i think it should be ready by monday. i will also add the missing iscsi_create which is a few lines only then. peter > > Paolo