From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59201)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TZIsh-0007Y6-1b
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:10:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TZIsd-0000mc-VI
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:10:38 -0500
Received: from e23smtp04.au.ibm.com ([202.81.31.146]:54643)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TZIsd-0000mV-D6
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:10:35 -0500
Received: from /spool/local
	by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Fri, 16 Nov 2012 20:05:25 +1000
Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	qAGA00NB65798222
	for <qemu-devel@nongnu.org>; Fri, 16 Nov 2012 21:00:01 +1100
Received: from d23av04.au.ibm.com (loopback [127.0.0.1])
	by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	qAGAAPT3006677
	for <qemu-devel@nongnu.org>; Fri, 16 Nov 2012 21:10:25 +1100
Message-ID: <50A6109A.6020902@linux.vnet.ibm.com>
Date: Fri, 16 Nov 2012 18:08:26 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1353042317-13688-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1353042317-13688-2-git-send-email-xiawenc@linux.vnet.ibm.com>
	<CAFEAcA-4OvTkgAV-Jx0hZ6c8CaYG+rckpxHqK8_g6OqhQON=+A@mail.gmail.com>
In-Reply-To: <CAFEAcA-4OvTkgAV-Jx0hZ6c8CaYG+rckpxHqK8_g6OqhQON=+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in
	pixman
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com

于 2012-11-16 17:27, Peter Maydell 写道:
> On 16 November 2012 05:05, Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>>    Currently if pixman have no config.log inside, make file still
>> try to clean it resulting error. This patch fix it.
>>
>> -       test -f pixman/config.log && make -C pixman distclean
>> +       @if test -f pixman/config.log; \
>> +       then \
>> +               make -C pixman distclean;\
>> +       fi
>
> These two bits of shellscript both do the same thing, don't they?
>
> -- PMM
>
   Looks the same, but on my machine
make -C pixman distclean
got executed resulting error, I guess that is what original author
wants to avoid.
   I'll conclude this patch into my libqblock patch serials to make
it easier to be reviwed.


-- 
Best Regards

Wenchao Xia