From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZJ4q-0005vx-Qx
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:23:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZJ4n-0003WY-OO
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:23:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47033)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZJ4n-0003WS-Fn
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:23:09 -0500
Message-ID: <50A61404.7060903@redhat.com>
Date: Fri, 16 Nov 2012 11:23:00 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1353042317-13688-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1353042317-13688-2-git-send-email-xiawenc@linux.vnet.ibm.com>
	<CAFEAcA-4OvTkgAV-Jx0hZ6c8CaYG+rckpxHqK8_g6OqhQON=+A@mail.gmail.com>
In-Reply-To: <CAFEAcA-4OvTkgAV-Jx0hZ6c8CaYG+rckpxHqK8_g6OqhQON=+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in
	pixman
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, Gerd Hoffmann <kraxel@redhat.com>, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

Il 16/11/2012 10:27, Peter Maydell ha scritto:
> On 16 November 2012 05:05, Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>>   Currently if pixman have no config.log inside, make file still
>> try to clean it resulting error. This patch fix it.
>>
>> -       test -f pixman/config.log && make -C pixman distclean
>> +       @if test -f pixman/config.log; \
>> +       then \
>> +               make -C pixman distclean;\
>> +       fi
> 
> These two bits of shellscript both do the same thing, don't they?

No, when "test" fails the && exits with a failure.  The "if" exits with
a success (not the most portable thing ever, but we assume a decent
shell elsewhere).

I think this patch is ok, but why the "@"?