qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] "usb: uhci: Look up queue by address, not token"
Date: Fri, 16 Nov 2012 11:25:27 +0100	[thread overview]
Message-ID: <50A61497.90003@redhat.com> (raw)
In-Reply-To: <50A50CD7.4070104@siemens.com>

On 11/15/12 16:40, Jan Kiszka wrote:
> Hi Hans,
> 
> On 2012-11-15 16:19, Hans de Goede wrote:
>> Hi Jan,
>>
>> I just saw your $subject patch in Gerd's usb-next tree, and I've a question
>> about it. The token should be enough to uniquely identify a device + ep,
>> and unless a guest uses multiple qhs for a singe ep, that _should_ be enough.
> 
> But what disallows that the guest issues multiple requests (QH + series
> of TDs) for a single endpoint? I'm not finding any trace in the spec
> that disallows this. And my special guest is stumbling over that
> limitation in QEMU.

The order which the TDs from the two QHs are filled is undefined I
think, so why a guest would do that?

I guess I'll push back the patch in the queue and don't include it into
the 1.3 pull req until this is sorted.

cheers,
  Gerd

  reply	other threads:[~2012-11-16 10:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-15 15:19 [Qemu-devel] "usb: uhci: Look up queue by address, not token" Hans de Goede
2012-11-15 15:40 ` Jan Kiszka
2012-11-16 10:25   ` Gerd Hoffmann [this message]
2012-11-16 11:24     ` Jan Kiszka
2012-11-16 13:43       ` Gerd Hoffmann
2012-11-17 10:22         ` Hans de Goede
2012-11-16 13:29   ` Hans de Goede
2012-11-16 15:06     ` Jan Kiszka
2012-11-17 10:20       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A61497.90003@redhat.com \
    --to=kraxel@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).