From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33822) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJA7-00026x-Un for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:28:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZJA4-0004wB-Qy for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:28:39 -0500 Received: from e28smtp08.in.ibm.com ([122.248.162.8]:38074) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJA4-0004v5-69 for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:28:36 -0500 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 16 Nov 2012 15:58:33 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay04.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qAGASSJ357540710 for ; Fri, 16 Nov 2012 15:58:29 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qAGFw9qP028756 for ; Sat, 17 Nov 2012 02:58:09 +1100 Message-ID: <50A6151F.9060405@linux.vnet.ibm.com> Date: Fri, 16 Nov 2012 18:27:43 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1353042317-13688-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1353042317-13688-2-git-send-email-xiawenc@linux.vnet.ibm.com> <50A6109A.6020902@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in pixman List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, pbonzini@redhat.com 于 2012-11-16 18:16, Peter Maydell 写道: > On 16 November 2012 10:08, Wenchao Xia wrote: >> 于 2012-11-16 17:27, Peter Maydell 写道: >>> On 16 November 2012 05:05, Wenchao Xia wrote: >>>> - test -f pixman/config.log && make -C pixman distclean >>>> + @if test -f pixman/config.log; \ >>>> + then \ >>>> + make -C pixman distclean;\ >>>> + fi > >>> These two bits of shellscript both do the same thing, don't they? > >> Looks the same, but on my machine >> make -C pixman distclean >> got executed resulting error, I guess that is what original author >> wants to avoid. > > If your shell executes Y in "X && Y" even if X fails, then your > shell is badly badly broken. More likely, there is some other > problem, and you need to find out what it is. > I don't think this patch should be applied, I'm afraid. > > -- PMM > My shell is OK, I missed the error reporting source before, in my test I think it is first part reporting error, that is "test -f pixman/config.log" directly report error. This patch would eliminate this error. -- Best Regards Wenchao Xia