From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJJe-0006D2-8H for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:38:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZJJb-0007aV-6J for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:38:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3858) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZJJa-0007aQ-VH for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:38:27 -0500 Message-ID: <50A6179C.5070104@redhat.com> Date: Fri, 16 Nov 2012 11:38:20 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <50A50150.8010201@dlhnet.de> <50A5101E.1030705@redhat.com> <50A51A52.4000807@redhat.com> In-Reply-To: <50A51A52.4000807@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] iscsi: fix deadlock during login List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Peter Lieven , "qemu-devel@nongnu.org" , ronnie sahlberg Am 15.11.2012 17:37, schrieb Paolo Bonzini: > Il 15/11/2012 17:13, ronnie sahlberg ha scritto: >> On Thu, Nov 15, 2012 at 7:54 AM, Paolo Bonzini wrote: >>> Il 15/11/2012 15:57, ronnie sahlberg ha scritto: >>>> I dont know if we should switch to use synchronous code here. >>>> It is much nicer if all code is async. >>> >>> bdrv_open is generally synchronous, so I think Peter's patch is ok. >> >> I was thinking about the case where you disconnect/reconnect a device >> at runtime. Like swapping the medium in a CDROM. >> If bdrv_open() is synchronous and blocks for a long time, would that >> not impact the rest of QEMU? > > Yes, it's not optimal, but VCPUs would still run until they request I/O. > But usually iscsi devices should be non-removable, no? That leaves > hotplug as the only problematic case. I guess we need a bdrv_co_open() for the long term. Kevin