From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60963)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TZJYm-0005MF-C9
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:54:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TZJYj-0003Xp-9Q
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:54:08 -0500
Received: from e28smtp01.in.ibm.com ([122.248.162.1]:37040)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1TZJYi-0003UR-KY
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 05:54:05 -0500
Received: from /spool/local
	by e28smtp01.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Fri, 16 Nov 2012 16:24:01 +0530
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay02.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	qAGArwQ422610070
	for <qemu-devel@nongnu.org>; Fri, 16 Nov 2012 16:23:58 +0530
Received: from d28av02.in.ibm.com (loopback [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	qAGGM1Jc009332
	for <qemu-devel@nongnu.org>; Sat, 17 Nov 2012 03:22:02 +1100
Message-ID: <50A61B38.8050605@linux.vnet.ibm.com>
Date: Fri, 16 Nov 2012 18:53:44 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1353042317-13688-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1353042317-13688-2-git-send-email-xiawenc@linux.vnet.ibm.com>
	<CAFEAcA-4OvTkgAV-Jx0hZ6c8CaYG+rckpxHqK8_g6OqhQON=+A@mail.gmail.com>
	<50A61404.7060903@redhat.com>
	<CAFEAcA_mVFtngDQ0ZHvQ=n-pfRy9q3110R3uefagtMWjKRqWcQ@mail.gmail.com>
	<50A617AC.5030606@redhat.com>
In-Reply-To: <50A617AC.5030606@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/2] Buildsystem fix distclean error in
	pixman
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: kwolf@redhat.com, Peter Maydell <peter.maydell@linaro.org>, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, Paolo Bonzini <pbonzini@redhat.com>

于 2012-11-16 18:38, Gerd Hoffmann 写道:
> On 11/16/12 11:26, Peter Maydell wrote:
>> On 16 November 2012 10:23, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>> Il 16/11/2012 10:27, Peter Maydell ha scritto:
>>>> On 16 November 2012 05:05, Wenchao Xia <xiawenc@linux.vnet.ibm.com> wrote:
>>>>> -       test -f pixman/config.log && make -C pixman distclean
>>>>> +       @if test -f pixman/config.log; \
>>>>> +       then \
>>>>> +               make -C pixman distclean;\
>>>>> +       fi
>>>>
>>>> These two bits of shellscript both do the same thing, don't they?
>>>
>>> No, when "test" fails the && exits with a failure.  The "if" exits with
>>> a success (not the most portable thing ever, but we assume a decent
>>> shell elsewhere).
>>
>> Aha. I love shell. (This detail could usefully have been
>> provided in the commit message...)
>
> Agree.  Can I get a version with an updated commit message for the
> pixman patch queue?
>
> thanks,
>    Gerd
>
   Sure,I'll resend according to more comments later.


-- 
Best Regards

Wenchao Xia