From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58691)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZJqU-00086C-TC
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:12:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZJqR-00006B-QX
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:12:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:49269)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TZJqR-000065-JZ
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 06:12:23 -0500
Message-ID: <50A61F90.3050306@redhat.com>
Date: Fri, 16 Nov 2012 12:12:16 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1353060737-4244-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1353060737-4244-4-git-send-email-xiawenc@linux.vnet.ibm.com>
	<50A61B7A.20906@redhat.com> <50A61C73.7000106@linux.vnet.ibm.com>
In-Reply-To: <50A61C73.7000106@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to
	Makefile.objs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com

Il 16/11/2012 11:58, Wenchao Xia ha scritto:
>>>    Sub Makefile may need qapi generated files, so move them to
>>> Makefile.objs,
>>> In this way Makfile.objs control file auto generation.
>>
>> No objection in principle, but why are you doing this?  Does it fix
>> anything?
> 
>   It seems tools or block objects files are depending on qapi files,

Yes, block files are.

> and libqblock needs tools. So without it out of tree build of libqblock
> would fail.

The effect of this patch is to include the rules in libqblock's own
Makefile.

libqblock indeed needs to compile these files to .lo.  However,
regeneration of the C source code and header shouldn't be needed there.
 I think you're missing a dependency in the toplevel Makefile's
"libqblock.la" rule.

By the way, do not name that rule "libqblock.la".  It doesn't build
libqblock.la, it builds libqblock/libqblock.la.  Instead, name it
subdir-libqblock.

Paolo