From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/7] target-mips: generate a reserved instruction exception on CPU without DSP
Date: Fri, 16 Nov 2012 14:02:58 -0800 [thread overview]
Message-ID: <50A6B812.4070802@twiddle.net> (raw)
In-Reply-To: <1353063863-11446-3-git-send-email-aurelien@aurel32.net>
On 11/16/2012 03:04 AM, Aurelien Jarno wrote:
> +static inline void check_dsp(CPUMIPSState *env, DisasContext *ctx)
> {
> if (unlikely(!(ctx->hflags & MIPS_HFLAG_DSP))) {
> - generate_exception(ctx, EXCP_DSPDIS);
> + if (env->insn_flags & ASE_DSP) {
> + generate_exception(ctx, EXCP_DSPDIS);
> + } else {
> + generate_exception(ctx, EXCP_RI);
> + }
Perhaps it would make more sense to copy env->insn_flags into
a new field in DisasContext at the start of translation, rather
than modify 300 instances to pass around a second pointer?
r~
next prev parent reply other threads:[~2012-11-16 22:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 11:04 [Qemu-devel] [PATCH 0/7] target-mips: DSP ASE fixes and cleanup Aurelien Jarno
2012-11-16 11:04 ` [Qemu-devel] [PATCH 1/7] target-mips: fix DSP loads with rd = 0 Aurelien Jarno
2012-11-21 6:28 ` Johnson, Eric
2012-11-16 11:04 ` [Qemu-devel] [PATCH 2/7] target-mips: generate a reserved instruction exception on CPU without DSP Aurelien Jarno
2012-11-16 22:02 ` Richard Henderson [this message]
2012-11-21 6:51 ` Johnson, Eric
2012-11-16 11:04 ` [Qemu-devel] [PATCH 3/7] target-mips: add unions to access DSP elements Aurelien Jarno
2012-11-21 6:54 ` Johnson, Eric
2012-11-16 11:04 ` [Qemu-devel] [PATCH 4/7] target-mips: use DSP unions for binary DSP operators Aurelien Jarno
2012-11-16 22:04 ` Richard Henderson
2012-12-05 4:58 ` Johnson, Eric
2012-11-16 11:04 ` [Qemu-devel] [PATCH 5/7] target-mips: use DSP unions for unary " Aurelien Jarno
2012-12-05 4:58 ` Johnson, Eric
2012-11-16 11:04 ` [Qemu-devel] [PATCH 6/7] target-mips: use DSP unions for reduction add instructions Aurelien Jarno
2012-12-05 4:58 ` Johnson, Eric
2012-11-16 11:04 ` [Qemu-devel] [PATCH 7/7] target-mips: implement DSP (d)append sub-class with TCG Aurelien Jarno
2012-12-05 4:58 ` Johnson, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A6B812.4070802@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).