From: Paolo Bonzini <pbonzini@redhat.com>
To: Bug 1080086 <1080086@bugs.launchpad.net>
Cc: Alex Horn <alex.horn@cs.ox.ac.uk>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.
Date: Sun, 18 Nov 2012 09:52:39 +0100 [thread overview]
Message-ID: <50A8A1D7.9050309@redhat.com> (raw)
In-Reply-To: <20121117184720.23777.80355.malone@gac.canonical.com>
Il 17/11/2012 19:47, Alex Horn ha scritto:
> I have attached a patch for the most recent version of the file
> hw/mc146818rtc.c [1]. The patch also features a functional test which
> executes through the QTest framework.
>
> I would appreciate your thoughts on this.
>
> [1]
> http://git.qemu.org/?p=qemu.git;a=blob;f=hw/mc146818rtc.c;h=98839f278d93452d071054e2a017b3d909b45ab2;hb=9cb535fe4ef08b01e583ec955767a0899ff79afe#l563
>
> ** Patch added: "register_b_set_flag.patch"
> https://bugs.launchpad.net/qemu/+bug/1080086/+attachment/3436808/+files/register_b_set_flag.patch
>
Hi Alex, the patch is almost good for inclusion. I'd ask for two
changes: 1) please test == 0, not != REG_B_SET; 2) please leave the
fuzzing test last, because it may leave some registers in an undefined
state.
Paolo
next prev parent reply other threads:[~2012-11-18 8:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 14:41 [Qemu-devel] [Bug 1080086] [NEW] MC146818 RTC breaks when SET bit in Register B is on Alex Horn
2012-11-17 18:47 ` [Qemu-devel] [Bug 1080086] " Alex Horn
2012-11-18 8:52 ` Paolo Bonzini [this message]
2012-11-19 11:34 ` Alex Horn
2012-11-19 11:42 ` Paolo Bonzini
2012-11-19 14:14 ` Alex Horn
2012-11-19 11:44 ` Paolo Bonzini
2012-11-19 12:12 ` Alex Horn
2012-11-19 12:42 ` Alex Horn
2017-11-07 18:42 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A8A1D7.9050309@redhat.com \
--to=pbonzini@redhat.com \
--cc=1080086@bugs.launchpad.net \
--cc=alex.horn@cs.ox.ac.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).