From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:32957)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ta0ce-0003WG-F4
	for qemu-devel@nongnu.org; Sun, 18 Nov 2012 03:53:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ta0cb-0006Cs-Cq
	for qemu-devel@nongnu.org; Sun, 18 Nov 2012 03:53:00 -0500
Received: from mail-ea0-f173.google.com ([209.85.215.173]:41309)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Ta0cb-0006Cd-5O
	for qemu-devel@nongnu.org; Sun, 18 Nov 2012 03:52:57 -0500
Received: by mail-ea0-f173.google.com with SMTP id i13so1690762eaa.4
	for <qemu-devel@nongnu.org>; Sun, 18 Nov 2012 00:52:55 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50A8A1D7.9050309@redhat.com>
Date: Sun, 18 Nov 2012 09:52:39 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20121117144135.13758.80176.malonedeb@wampee.canonical.com>
	<20121117184720.23777.80355.malone@gac.canonical.com>
In-Reply-To: <20121117184720.23777.80355.malone@gac.canonical.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit
 in Register B is on.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bug 1080086 <1080086@bugs.launchpad.net>
Cc: Alex Horn <alex.horn@cs.ox.ac.uk>, qemu-devel@nongnu.org

Il 17/11/2012 19:47, Alex Horn ha scritto:
> I have attached a patch for the most recent version of the file
> hw/mc146818rtc.c [1]. The patch also features a functional test which
> executes through the QTest framework.
> 
> I would appreciate your thoughts on this.
> 
> [1]
> http://git.qemu.org/?p=qemu.git;a=blob;f=hw/mc146818rtc.c;h=98839f278d93452d071054e2a017b3d909b45ab2;hb=9cb535fe4ef08b01e583ec955767a0899ff79afe#l563
> 
> ** Patch added: "register_b_set_flag.patch"
>    https://bugs.launchpad.net/qemu/+bug/1080086/+attachment/3436808/+files/register_b_set_flag.patch
> 

Hi Alex, the patch is almost good for inclusion.  I'd ask for two
changes: 1) please test == 0, not != REG_B_SET; 2) please leave the
fuzzing test last, because it may leave some registers in an undefined
state.

Paolo