From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu-common: Add definition for O_NONBLOCK
Date: Sun, 18 Nov 2012 09:55:00 +0100 [thread overview]
Message-ID: <50A8A264.4090705@redhat.com> (raw)
In-Reply-To: <1353170443-18168-1-git-send-email-sw@weilnetz.de>
Il 17/11/2012 17:40, Stefan Weil ha scritto:
> backends/rng-random.c which was added by commit
> 5c74521d249486fa3e749dbbf6d56a70d4d7235f needs
> macro O_NONBLOCK.
>
> The macro O_NONBLOCK is not defined for all hosts.
> Adding a default definition fixes builds for MinGW.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>
> This is a build fix. Therefore I'd appreciate if it could be
> committed soon.
This would make things blocking when they were supposed to be
nonblocking, so I'd prefer not including it. I thought Anthony had a
fix too?
Paolo
next prev parent reply other threads:[~2012-11-18 8:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-17 16:40 [Qemu-devel] [PATCH] qemu-common: Add definition for O_NONBLOCK Stefan Weil
2012-11-18 8:55 ` Paolo Bonzini [this message]
2012-11-18 10:41 ` Stefan Weil
2012-12-03 12:52 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A8A264.4090705@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).