qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] rng-random: only build on POSIX platforms
Date: Sun, 18 Nov 2012 11:29:16 +0100	[thread overview]
Message-ID: <50A8B87C.5000601@weilnetz.de> (raw)
In-Reply-To: <1353159697-3922-1-git-send-email-aliguori@us.ibm.com>

Am 17.11.2012 14:41, schrieb Anthony Liguori:
> There is no /dev/random on win32.
>
> Cc: Stefan Weil<weil@mail.berlios.de>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
> ---
>   backends/Makefile.objs | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/backends/Makefile.objs b/backends/Makefile.objs
> index 875eebc..8836761 100644
> --- a/backends/Makefile.objs
> +++ b/backends/Makefile.objs
> @@ -1 +1,2 @@
> -common-obj-y += rng.o rng-random.o rng-egd.o
> +common-obj-y += rng.o rng-egd.o
> +common-obj-$(CONFIG_POSIX) += rng-random.o

The patch fixes a build issue on w32 / w64, but the reason given
is misleading: yes, Windows has no /dev files, but the MinGW
library tries to emulate the most important interfaces from /dev.

There is a /dev/random with MinGW, and it does what it is supposed
to do. See this URL for more supported "devices":
http://srv.onzk.net/linwin/apache-php3-mysql/CygWin_20b_98-4_Documents_OnLine/CygWin-Ug-Net/using-specialnames.html

Regards
Stefan W.

  reply	other threads:[~2012-11-18 10:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-17 13:41 [Qemu-devel] [PATCH] rng-random: only build on POSIX platforms Anthony Liguori
2012-11-18 10:29 ` Stefan Weil [this message]
2012-11-18 14:44   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50A8B87C.5000601@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aliguori@us.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).