From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44346) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta4RN-0002nb-T7 for qemu-devel@nongnu.org; Sun, 18 Nov 2012 07:57:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ta4RK-0004Se-QV for qemu-devel@nongnu.org; Sun, 18 Nov 2012 07:57:37 -0500 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:47233) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta4RK-0004ST-93 for qemu-devel@nongnu.org; Sun, 18 Nov 2012 07:57:34 -0500 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 18 Nov 2012 22:53:21 +1000 Received: from d23av04.au.ibm.com (d23av04.au.ibm.com [9.190.235.139]) by d23relay05.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qAICkhS227983952 for ; Sun, 18 Nov 2012 23:46:44 +1100 Received: from d23av04.au.ibm.com (loopback [127.0.0.1]) by d23av04.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qAICvKLq001380 for ; Sun, 18 Nov 2012 23:57:20 +1100 Message-ID: <50A8DB16.40605@linux.vnet.ibm.com> Date: Sun, 18 Nov 2012 20:56:54 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1353060737-4244-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1353060737-4244-4-git-send-email-xiawenc@linux.vnet.ibm.com> <50A61B7A.20906@redhat.com> <50A61C73.7000106@linux.vnet.ibm.com> <50A61F90.3050306@redhat.com> In-Reply-To: <50A61F90.3050306@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Makefile.objs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com 于 2012-11-16 19:12, Paolo Bonzini 写道: > Il 16/11/2012 11:58, Wenchao Xia ha scritto: >>>> Sub Makefile may need qapi generated files, so move them to >>>> Makefile.objs, >>>> In this way Makfile.objs control file auto generation. >>> >>> No objection in principle, but why are you doing this? Does it fix >>> anything? >> >> It seems tools or block objects files are depending on qapi files, > > Yes, block files are. > >> and libqblock needs tools. So without it out of tree build of libqblock >> would fail. > > The effect of this patch is to include the rules in libqblock's own > Makefile. > > libqblock indeed needs to compile these files to .lo. However, > regeneration of the C source code and header shouldn't be needed there. > I think you're missing a dependency in the toplevel Makefile's > "libqblock.la" rule. > yes, I'll try avoid generation of those C files in sub directory. Still moving generation rules all into Makefile.obs seems right to me. > By the way, do not name that rule "libqblock.la". It doesn't build > libqblock.la, it builds libqblock/libqblock.la. Instead, name it > subdir-libqblock. OK. > > Paolo > -- Best Regards Wenchao Xia