From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta6Hw-0005E1-EA for qemu-devel@nongnu.org; Sun, 18 Nov 2012 09:56:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ta6Ht-0002H0-Bu for qemu-devel@nongnu.org; Sun, 18 Nov 2012 09:56:00 -0500 Received: from mail-wi0-f181.google.com ([209.85.212.181]:38107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta6Ht-0002Gr-5N for qemu-devel@nongnu.org; Sun, 18 Nov 2012 09:55:57 -0500 Received: by mail-wi0-f181.google.com with SMTP id hm2so2173239wib.10 for ; Sun, 18 Nov 2012 06:55:56 -0800 (PST) Sender: Paolo Bonzini Message-ID: <50A8F6F9.4000506@redhat.com> Date: Sun, 18 Nov 2012 15:55:53 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1353060737-4244-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1353060737-4244-4-git-send-email-xiawenc@linux.vnet.ibm.com> <50A61B7A.20906@redhat.com> <50A61C73.7000106@linux.vnet.ibm.com> <50A61F90.3050306@redhat.com> <50A8DB16.40605@linux.vnet.ibm.com> In-Reply-To: <50A8DB16.40605@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V9 3/8] Buildsystem move qapi generation to Makefile.objs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com Il 18/11/2012 13:56, Wenchao Xia ha scritto: > 于 2012-11-16 19:12, Paolo Bonzini 写道: >> Il 16/11/2012 11:58, Wenchao Xia ha scritto: >>>>> Sub Makefile may need qapi generated files, so move them to >>>>> Makefile.objs, >>>>> In this way Makfile.objs control file auto generation. >>>> >>>> No objection in principle, but why are you doing this? Does it fix >>>> anything? >>> >>> It seems tools or block objects files are depending on qapi files, >> >> Yes, block files are. >> >>> and libqblock needs tools. So without it out of tree build of libqblock >>> would fail. >> >> The effect of this patch is to include the rules in libqblock's own >> Makefile. >> >> libqblock indeed needs to compile these files to .lo. However, >> regeneration of the C source code and header shouldn't be needed there. >> I think you're missing a dependency in the toplevel Makefile's >> "libqblock.la" rule. >> > yes, I'll try avoid generation of those C files in sub directory. > Still moving generation rules all into Makefile.obs seems right to me. Makefile.objs rules are common to all subdirectories, including *-softmmu and *-linux-user. This is not what you want in this case. Paolo