From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: amit shah <amit.shah@redhat.com>, Alon Levy <alevy@redhat.com>,
qemu-devel@nongnu.org, alexl@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running
Date: Mon, 19 Nov 2012 09:19:44 +0100 [thread overview]
Message-ID: <50A9EBA0.7090002@redhat.com> (raw)
In-Reply-To: <CAAu8pHtsbV-DCphsaXemawiZy2QDE459YaEeKMvDSrvep+n4HA@mail.gmail.com>
Il 18/11/2012 20:17, Blue Swirl ha scritto:
>>>> >> > + struct {
>>> >>
>>> >> Please add a name, for example PostLoad.
>> >
>> > Why? This is not C++ and the namespace would be global. It's just to
>> > have a nice grouping.
> Otherwise the structure will be anonymous and those were only added to
> C11, not C99.
No, the name here is "post_load". Unnamed struct *types* are present
all the way to C89 and probably even K&R.
Paolo
>> >
>> > Paolo
>> >
>>>> >> > + QEMUTimer *timer;
>>>> >> > + int nr_active_ports;
>>>> >> > + struct {
>>>> >> > + VirtIOSerialPort *port;
>>>> >> > + uint8_t host_connected;
>>>> >> > + } *connected;
>>>> >> > + } post_load;
prev parent reply other threads:[~2012-11-19 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-14 13:09 [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event when vm is running Alon Levy
2012-11-14 13:20 ` Paolo Bonzini
2012-11-16 8:30 ` Amit Shah
2012-11-17 16:08 ` Blue Swirl
2012-11-18 16:29 ` Paolo Bonzini
2012-11-18 19:17 ` Blue Swirl
2012-11-19 8:19 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50A9EBA0.7090002@redhat.com \
--to=pbonzini@redhat.com \
--cc=alevy@redhat.com \
--cc=alexl@redhat.com \
--cc=amit.shah@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).