From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35700)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TaMa9-0004bH-IH
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 03:19:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TaMa6-0005Vy-FK
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 03:19:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44059)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1TaMa6-0005Vm-7a
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 03:19:50 -0500
Message-ID: <50A9EBA0.7090002@redhat.com>
Date: Mon, 19 Nov 2012 09:19:44 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <CAAu8pHvA01or2RoYnzP3ZHpxh_iruYCkbRwOuiBjZbTFj6bntQ@mail.gmail.com>
	<1262482193.11614629.1353256165864.JavaMail.root@redhat.com>
	<CAAu8pHtsbV-DCphsaXemawiZy2QDE459YaEeKMvDSrvep+n4HA@mail.gmail.com>
In-Reply-To: <CAAu8pHtsbV-DCphsaXemawiZy2QDE459YaEeKMvDSrvep+n4HA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/virtio-serial-bus: post_load send_event
 when vm is running
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: amit shah <amit.shah@redhat.com>, Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org, alexl@redhat.com

Il 18/11/2012 20:17, Blue Swirl ha scritto:
>>>> >> > +    struct {
>>> >>
>>> >> Please add a name, for example PostLoad.
>> >
>> > Why?  This is not C++ and the namespace would be global.  It's just to
>> > have a nice grouping.
> Otherwise the structure will be anonymous and those were only added to
> C11, not C99.

No, the name here is "post_load".  Unnamed struct *types* are present
all the way to C89 and probably even K&R.

Paolo

>> >
>> > Paolo
>> >
>>>> >> > +        QEMUTimer *timer;
>>>> >> > +        int nr_active_ports;
>>>> >> > +        struct {
>>>> >> > +            VirtIOSerialPort *port;
>>>> >> > +            uint8_t host_connected;
>>>> >> > +        } *connected;
>>>> >> > +    } post_load;