* [Qemu-devel] [PATCH] Fix the inconsistency in x509-dh-key-file parameter
@ 2012-11-15 7:09 Lei Li
0 siblings, 0 replies; 3+ messages in thread
From: Lei Li @ 2012-11-15 7:09 UTC (permalink / raw)
To: qemu-devel; +Cc: Lei Li
Fix the inconsistency between the declaration of the
option 'x509-dh-key-file' to -spice command line and
its parameter parsing.
https://bugs.launchpad.net/qemu/+bug/1035042
Reported-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
ui/spice-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 5147365..261c6f2 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -610,7 +610,7 @@ void qemu_spice_init(void)
}
x509_key_password = qemu_opt_get(opts, "x509-key-password");
- x509_dh_file = qemu_opt_get(opts, "x509-dh-file");
+ x509_dh_file = qemu_opt_get(opts, "x509-dh-key-file");
tls_ciphers = qemu_opt_get(opts, "tls-ciphers");
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] Fix the inconsistency in x509-dh-key-file parameter
@ 2012-11-19 9:15 Lei Li
2012-11-19 9:59 ` Gerd Hoffmann
0 siblings, 1 reply; 3+ messages in thread
From: Lei Li @ 2012-11-19 9:15 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel, Lei Li
Commit c448e8552b0f6135dabddf944a7110f929c08320 (spice: tls
support) added options to the -spice command line. But there
is an inconsistency between the declaration of the option
'x509-dh-key-file' to -spice command line and its parameter
parsing 'x509-dh-file' in function qemu_spice_init.
https://bugs.launchpad.net/qemu/+bug/1035042
Reported-by: Alon Bar-Lev <alon.barlev@gmail.com>
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
ui/spice-core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/ui/spice-core.c b/ui/spice-core.c
index 5147365..261c6f2 100644
--- a/ui/spice-core.c
+++ b/ui/spice-core.c
@@ -610,7 +610,7 @@ void qemu_spice_init(void)
}
x509_key_password = qemu_opt_get(opts, "x509-key-password");
- x509_dh_file = qemu_opt_get(opts, "x509-dh-file");
+ x509_dh_file = qemu_opt_get(opts, "x509-dh-key-file");
tls_ciphers = qemu_opt_get(opts, "tls-ciphers");
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Fix the inconsistency in x509-dh-key-file parameter
2012-11-19 9:15 [Qemu-devel] [PATCH] Fix the inconsistency in x509-dh-key-file parameter Lei Li
@ 2012-11-19 9:59 ` Gerd Hoffmann
0 siblings, 0 replies; 3+ messages in thread
From: Gerd Hoffmann @ 2012-11-19 9:59 UTC (permalink / raw)
To: Lei Li; +Cc: qemu-devel
On 11/19/12 10:15, Lei Li wrote:
> Commit c448e8552b0f6135dabddf944a7110f929c08320 (spice: tls
> support) added options to the -spice command line. But there
> is an inconsistency between the declaration of the option
> 'x509-dh-key-file' to -spice command line and its parameter
> parsing 'x509-dh-file' in function qemu_spice_init.
Patch added to spice patch queue.
thanks,
Gerd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-19 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-19 9:15 [Qemu-devel] [PATCH] Fix the inconsistency in x509-dh-key-file parameter Lei Li
2012-11-19 9:59 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2012-11-15 7:09 Lei Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).