Re: [Qemu-devel] [PATCH] vnc: added initial websockets support

[Tim Hardeck <thardeck@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1535 bytes --]

On 11/19/2012 10:07 AM, Stefan Hajnoczi wrote:
> On Mon, Nov 19, 2012 at 12:29:44AM +0100, Tim Hardeck wrote:
>> Hi Stefan,
>>
>> thanks for your input but how should it be implemented?
>>
>> I personally would like activating Websockets as a VNC option like: "
>> -vnc :0 -vnc :1,websockets"
>> I have already tested this locally and it does work but only for one
>> protocol since QEMU does only interpret the last vnc option.
>> So is allowing more than one VNC command line entry in combination with
>> having more than one VNC thread for the same display worth working on or
>> do you have something different in mind?
> 
> I'm not familiar enough with the VNC code to suggest how to best
> implement this.
> 
> One thing to think about is that Websockets is a transport.  Perhaps the
> VNC code itself shouldn't speak it, instead generic QEMU socket code
> should implement Websockets so that non-VNC components can also make use
> of it in the future.
I have talked about this with a colleague and it seems like quite some
effort for no use case besides VNC.
It might be interesting in the long run though.

Is the rest of my implementation OK besides the protocol recognition by
timeout - which should only be an issue for high latency websockets
connection?

Regards
Tim


-- 
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix
Imendörffer, HRB 16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
T: +49 (0) 911 74053-0  F: +49 (0) 911 74053-483
http://www.suse.de/


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]