From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46342) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaO9a-0007Ov-5Y for qemu-devel@nongnu.org; Mon, 19 Nov 2012 05:00:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaO9U-0008OR-Di for qemu-devel@nongnu.org; Mon, 19 Nov 2012 05:00:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38368 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaO9U-0008NF-3X for qemu-devel@nongnu.org; Mon, 19 Nov 2012 05:00:28 -0500 Message-ID: <50AA0334.3060006@suse.de> Date: Mon, 19 Nov 2012 11:00:20 +0100 From: Tim Hardeck MIME-Version: 1.0 References: <1353078798-6472-1-git-send-email-thardeck@suse.de> <1353281384.3623.38.camel@Thinktank.site> <20121119090700.GA18034@stefanha-thinkpad.redhat.com> In-Reply-To: <20121119090700.GA18034@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0D39EA2D836BDEE4BCD01DB2" Subject: Re: [Qemu-devel] [PATCH] vnc: added initial websockets support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: github@martintribe.org, qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0D39EA2D836BDEE4BCD01DB2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 11/19/2012 10:07 AM, Stefan Hajnoczi wrote: > On Mon, Nov 19, 2012 at 12:29:44AM +0100, Tim Hardeck wrote: >> Hi Stefan, >> >> thanks for your input but how should it be implemented? >> >> I personally would like activating Websockets as a VNC option like: " >> -vnc :0 -vnc :1,websockets" >> I have already tested this locally and it does work but only for one >> protocol since QEMU does only interpret the last vnc option. >> So is allowing more than one VNC command line entry in combination wit= h >> having more than one VNC thread for the same display worth working on = or >> do you have something different in mind? >=20 > I'm not familiar enough with the VNC code to suggest how to best > implement this. >=20 > One thing to think about is that Websockets is a transport. Perhaps th= e > VNC code itself shouldn't speak it, instead generic QEMU socket code > should implement Websockets so that non-VNC components can also make us= e > of it in the future. I have talked about this with a colleague and it seems like quite some effort for no use case besides VNC. It might be interesting in the long run though. Is the rest of my implementation OK besides the protocol recognition by timeout - which should only be an issue for high latency websockets connection? Regards Tim --=20 SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer, HRB 16746 (AG N=FCrnberg) Maxfeldstr. 5, 90409 N=FCrnberg, Germany T: +49 (0) 911 74053-0 F: +49 (0) 911 74053-483 http://www.suse.de/ --------------enig0D39EA2D836BDEE4BCD01DB2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQEcBAEBAgAGBQJQqgM0AAoJENur/L6EMd67TsAH/Aju6qBG4q72SQwS+k9DvtjK rkODdlTw3p60bKVzaO3E4nasaevTJdV4TcCP+PlJgRpgdMo85GDR3tl9bxXAzz9V L8Jfa9WzbmGZCw8sG/vqA98Hmmh7UXSAc+SD52xO82mnNPWkB/ogVmisO8OSyv/I JF13jho7yLMFGtTUKrOsUo99pQAnifNtrgowCNBQBFRG35Lw5+94qyXD5vH6kTZp DEGJLS7ya5Nx12iqMiN8jhOyccCkGWsu0+XBvL078SGO5pd6QSFnuMd0r52w4lWC t953qqEIwSdwHIH68AGoN0yKRchhZVatXVnYw4w7wcZvKBc8k4Uq1Sqb1UsBVKY= =908K -----END PGP SIGNATURE----- --------------enig0D39EA2D836BDEE4BCD01DB2--