From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35690) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaR3q-0002rd-LH for qemu-devel@nongnu.org; Mon, 19 Nov 2012 08:06:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaR3n-0000Y7-JD for qemu-devel@nongnu.org; Mon, 19 Nov 2012 08:06:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaR3n-0000Xz-Bb for qemu-devel@nongnu.org; Mon, 19 Nov 2012 08:06:47 -0500 Message-ID: <50AA2EDF.6070409@redhat.com> Date: Mon, 19 Nov 2012 14:06:39 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <589082222.7272963.1352241778123.JavaMail.root@redhat.com> <50A95A6A.4010109@profihost.ag> <50A9E991.2070609@redhat.com> <50A9FD86.3050400@profihost.ag> <50AA01C0.8030709@redhat.com> <50AA0314.6090208@profihost.ag> <50AA04A7.4080200@redhat.com> <50AA065F.5010602@profihost.ag> <50AA089B.7010400@redhat.com> <50AA0A2E.2090506@profihost.ag> <50AA0B90.6060702@redhat.com> <50AA1085.6000106@profihost.ag> <50AA151A.7030008@redhat.com> <50AA1CE7.7090100@profihost.ag> <50AA24E7.7010009@redhat.com> <50AA2DB0.6010107@profihost.ag> In-Reply-To: <50AA2DB0.6010107@profihost.ag> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] scsi-hd with discard_granularity and unmap results in Aborted Commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Priebe - Profihost AG Cc: josh.durgin@inktank.com, qemu-devel@nongnu.org, sage@newdream.net Il 19/11/2012 14:01, Stefan Priebe - Profihost AG ha scritto: >> The right behavior is to return >> only after the target says whether the cancellation was done or not. >> For libiscsi, it was implemented by the commits you mention. > > So the whole bunch of changes is needed for rbd? Something like the first three: 1bd075f29ea6d11853475c7c42734595720c3ac6 cfb3f5064af2d2e29c976e292c9472dfe9d61e31 27cbd828c617944c0f9603763fdf4fa87e7ad923 Paolo