From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TalSm-0003DZ-R5 for qemu-devel@nongnu.org; Tue, 20 Nov 2012 05:54:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TalSi-0001FP-Nj for qemu-devel@nongnu.org; Tue, 20 Nov 2012 05:53:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53747) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TalSi-0001FA-FN for qemu-devel@nongnu.org; Tue, 20 Nov 2012 05:53:52 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qAKArp77011946 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 20 Nov 2012 05:53:51 -0500 Message-ID: <50AB613C.3060200@redhat.com> Date: Tue, 20 Nov 2012 11:53:48 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1353330711-20207-1-git-send-email-alexl@redhat.com> <50AB3631.2080000@redhat.com> <20121120090736.GA3461@redhat.com> <50AB4A2B.7060001@redhat.com> <1353404100.2180.39.camel@fatty> <50AB58AA.6060303@redhat.com> <1353407424.2180.44.camel@fatty> In-Reply-To: <1353407424.2180.44.camel@fatty> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qxl: Export "mode" as a property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Larsson Cc: Alon Levy , qemu-devel@nongnu.org Hi, > I know that, but it would be possible to add code to the driver to > register a version string. Sure. Although it is a bit more complex that just a simple string. With qxl guest drivers moving to kms as we'll have two driver components then. > Might be useful for qxl developers, but not very useful to e.g. a > helpdesk employee trying to solve an issue for a user, as its kinda > low-level. Depends on the problem. $feature not working and qxl seeing the driver not using the new ops for $feature is helpful. > Having the version string would be very nice here. Indeed, being able to match the driver version against a database of known-buggy versions is nice too. That will only work for new drivers which actually report the version though (assuming we go that route). But there we are again at the level where going through the guest agent might be a better way. "rpm -q kernel xorg-x11-drv-qxl" gives you what you need ... cheers, Gerd