From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56222) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TanKC-0001Z2-CM for qemu-devel@nongnu.org; Tue, 20 Nov 2012 07:53:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TanKB-0004jk-Cf for qemu-devel@nongnu.org; Tue, 20 Nov 2012 07:53:12 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44979) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TanKB-0004jZ-53 for qemu-devel@nongnu.org; Tue, 20 Nov 2012 07:53:11 -0500 Message-ID: <50AB7D32.9030207@redhat.com> Date: Tue, 20 Nov 2012 13:53:06 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1353414712-27072-1-git-send-email-stefanha@redhat.com> <1353414712-27072-9-git-send-email-stefanha@redhat.com> <20121120123708.GI3461@redhat.com> In-Reply-To: <20121120123708.GI3461@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 8/8] virtio-blk: add x-data-plane=on|off performance feature List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: Anthony Liguori , "Michael S. Tsirkin" , qemu-devel@nongnu.org, khoa@us.ibm.com, Stefan Hajnoczi , Paolo Bonzini , asias@redhat.com Am 20.11.2012 13:37, schrieb Daniel P. Berrange: > On Tue, Nov 20, 2012 at 01:31:52PM +0100, Stefan Hajnoczi wrote: >> The virtio-blk-data-plane feature is easy to integrate into >> hw/virtio-blk.c. The data plane can be started and stopped similar to >> vhost-net. >> >> Users can take advantage of the virtio-blk-data-plane feature using the >> new -device virtio-blk-pci,x-data-plane=on property. >> >> The x-data-plane name was chosen because at this stage the feature is >> experimental and likely to see changes in the future. > > Can you give some indication of how it is likely to change, since > this has a bearing on any libvirt use of this feature ? I suppose the intended semantics is "libvirt, don't touch this!" Maybe we could document the x-... prefix for experimental features that may be changed in incompatible ways or removed in future versions, and that no management tools should use. Kevin