From: Alexander Graf <agraf@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: kvm@vger.kernel.org, patches@linaro.org,
"Marcelo Tosatti" <mtosatti@redhat.com>,
qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
"Blue Swirl" <blauwirbel@gmail.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit transparent hugepages on ARM Linux
Date: Tue, 20 Nov 2012 14:54:29 +0100 [thread overview]
Message-ID: <50AB8B95.8000106@suse.de> (raw)
In-Reply-To: <1353418270-23881-9-git-send-email-peter.maydell@linaro.org>
On 11/20/2012 02:31 PM, Peter Maydell wrote:
> ARM Linux (like x86-64 Linux) can use transparent hugepages for
> KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN
> accordingly.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
> oslib-posix.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/oslib-posix.c b/oslib-posix.c
> index 9db9c3d..d25b52a 100644
> --- a/oslib-posix.c
> +++ b/oslib-posix.c
> @@ -35,7 +35,7 @@
> extern int daemon(int, int);
> #endif
>
> -#if defined(__linux__)&& defined(__x86_64__)
> +#if defined(__linux__)&& (defined(__x86_64__) || defined(__arm__))
Why not just drop the arch specific bit?
Alex
next prev parent reply other threads:[~2012-11-20 13:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 13:31 [Qemu-devel] [RFC v4 0/8] QEMU: Support KVM on ARM Peter Maydell
2012-11-20 13:31 ` [Qemu-devel] [RFC v4 1/8] linux-headers: Add ARM KVM headers (not for upstream) Peter Maydell
2012-11-20 13:31 ` [Qemu-devel] [RFC v4 2/8] ARM: KVM: Add support for KVM on ARM architecture Peter Maydell
2012-11-20 13:31 ` [Qemu-devel] [RFC v4 3/8] ARM KVM: save and load VFP registers from kernel Peter Maydell
2012-11-20 13:31 ` [Qemu-devel] [RFC v4 4/8] hw/arm_gic: Add presave/postload hooks Peter Maydell
2012-11-20 13:31 ` [Qemu-devel] [RFC v4 5/8] target-arm: Use MemoryListener to identify GIC base address for KVM Peter Maydell
2012-11-20 13:31 ` [Qemu-devel] [RFC v4 6/8] hw/kvm/arm_gic: Implement support for KVM in-kernel ARM GIC Peter Maydell
2012-11-20 13:31 ` [Qemu-devel] [RFC v4 7/8] configure: Enable KVM on ARM Peter Maydell
2012-11-20 13:31 ` [Qemu-devel] [RFC v4 8/8] oslib-posix: Align to permit transparent hugepages on ARM Linux Peter Maydell
2012-11-20 13:54 ` Alexander Graf [this message]
2012-11-20 13:55 ` [Qemu-devel] [kvmarm] " Christoffer Dall
2012-11-20 14:37 ` Alexander Graf
2012-11-20 14:48 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB8B95.8000106@suse.de \
--to=agraf@suse.de \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=mtosatti@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).