From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60421)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Taoxc-0004vO-Qc
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 09:38:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TaoxW-0006Io-TR
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 09:38:00 -0500
Received: from cantor2.suse.de ([195.135.220.15]:53636 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1TaoxW-0006IT-NP
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 09:37:54 -0500
Message-ID: <50AB95BE.1090406@suse.de>
Date: Tue, 20 Nov 2012 15:37:50 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1353418270-23881-1-git-send-email-peter.maydell@linaro.org>
	<1353418270-23881-9-git-send-email-peter.maydell@linaro.org>
	<50AB8B95.8000106@suse.de>
	<CANM98qJYVDcKLAvntbdQrwUcBG_miqoZU=yfGFcYey3b6yzYdw@mail.gmail.com>
In-Reply-To: <CANM98qJYVDcKLAvntbdQrwUcBG_miqoZU=yfGFcYey3b6yzYdw@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit
 transparent hugepages on ARM Linux
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoffer Dall <c.dall@virtualopensystems.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, kvm@vger.kernel.org, patches@linaro.org, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Blue Swirl <blauwirbel@gmail.com>, kvmarm@lists.cs.columbia.edu

On 11/20/2012 02:55 PM, Christoffer Dall wrote:
> On Tue, Nov 20, 2012 at 8:54 AM, Alexander Graf<agraf@suse.de>  wrote:
>> On 11/20/2012 02:31 PM, Peter Maydell wrote:
>>> ARM Linux (like x86-64 Linux) can use transparent hugepages for
>>> KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN
>>> accordingly.
>>>
>>> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
>>> ---
>>>    oslib-posix.c |    2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/oslib-posix.c b/oslib-posix.c
>>> index 9db9c3d..d25b52a 100644
>>> --- a/oslib-posix.c
>>> +++ b/oslib-posix.c
>>> @@ -35,7 +35,7 @@
>>>    extern int daemon(int, int);
>>>    #endif
>>>
>>> -#if defined(__linux__)&&   defined(__x86_64__)
>>> +#if defined(__linux__)&&   (defined(__x86_64__) || defined(__arm__))
>>
>> Why not just drop the arch specific bit?
>>
>>
> other archs have other alignment requirements, iirc.

Ah, sorry, missed the rest of the lines around this one :). Yeah, should 
be ok then.


Alex