From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49385) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Taq2I-0000eT-EK for qemu-devel@nongnu.org; Tue, 20 Nov 2012 10:47:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Taq21-0004Bf-OM for qemu-devel@nongnu.org; Tue, 20 Nov 2012 10:46:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3542) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Taq21-0004BW-H1 for qemu-devel@nongnu.org; Tue, 20 Nov 2012 10:46:37 -0500 Message-ID: <50ABA5D8.1090104@redhat.com> Date: Tue, 20 Nov 2012 16:46:32 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1353425657-3237-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1353425657-3237-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vdi: don't override libuuid symbols List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Stefan Weil , qemu-devel@nongnu.org, vbellur@redhat.com Am 20.11.2012 16:34, schrieb Stefan Hajnoczi: > It's poor symbol hygiene to provide a global symbols that collide with a > common library like libuuid. If QEMU links against a shared library > that depends on uuid_generate() it can end up calling our stub version > of the function. > > This exact scenario happened with GlusterFS libgfapi.so, which depends > on libglusterfs.so's uuid_generate(). > > Scope the uuid stubs for vdi.c only and avoid affecting other shared > objects. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Kevin Wolf