qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com,
	stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com,
	kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system
Date: Wed, 21 Nov 2012 08:56:40 +0100	[thread overview]
Message-ID: <50AC8938.9030708@redhat.com> (raw)
In-Reply-To: <50AC4467.4050101@linux.vnet.ibm.com>

Il 21/11/2012 04:03, Wenchao Xia ha scritto:
>>
>>> +libqblock="yes"
>>
>> Please make the default the empty string, i.e. "build if and only if
>> libtool is present".
>>
>   Do you mean adding a probe section later that if libtool is present,
> its default is "yes", else set it to "no"?

Here, you just do libqblock="".

Then --enable-libqblock and --disable-libqblock set it to yes or no.

Then, if $libqblock = yes, and no libtool, fail.

If $libqblock is empty, and no libtool, set it to no.

If $libqblock is empty, and libtool is there, set it to yes.

Paolo

  reply	other threads:[~2012-11-21  7:56 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20  9:46 [Qemu-devel] [PATCH V10 0/7] libqblock qemu block layer library Wenchao Xia
2012-11-20  9:46 ` [Qemu-devel] [PATCH V10 1/7] Buildsystem fix distclean error for pixman Wenchao Xia
2012-11-21 22:54   ` Peter Maydell
2012-11-22  1:50     ` Wenchao Xia
2012-11-20  9:46 ` [Qemu-devel] [PATCH V10 2/7] Buildsystem clean tests directory clearly Wenchao Xia
2012-11-20  9:46 ` [Qemu-devel] [PATCH V10 3/7] block export function path_has_protocol Wenchao Xia
2012-11-20  9:46 ` [Qemu-devel] [PATCH V10 4/7] libqblock build system Wenchao Xia
2012-11-20 10:26   ` Paolo Bonzini
2012-11-21  3:03     ` Wenchao Xia
2012-11-21  7:56       ` Paolo Bonzini [this message]
2012-11-22  1:47         ` Wenchao Xia
2012-11-20  9:46 ` [Qemu-devel] [PATCH V10 5/7] libqblock type defines Wenchao Xia
2012-11-20 10:30   ` Paolo Bonzini
2012-11-21  3:12     ` Wenchao Xia
2012-11-21  8:05       ` Paolo Bonzini
2012-11-22  1:50         ` Wenchao Xia
2012-11-20  9:46 ` [Qemu-devel] [PATCH V10 6/7] libqblock API Wenchao Xia
2012-11-20 10:41   ` Paolo Bonzini
2012-11-21  3:40     ` Wenchao Xia
2012-11-21  8:04       ` Paolo Bonzini
2012-11-22  1:48         ` Wenchao Xia
2012-11-20  9:46 ` [Qemu-devel] [PATCH V10 7/7] libqblock test example Wenchao Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AC8938.9030708@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    --cc=xiawenc@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).