From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tb5Ar-0005pE-Bu
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 02:56:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tb5Aq-0004dn-9L
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 02:56:45 -0500
Received: from mail-ea0-f173.google.com ([209.85.215.173]:44322)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Tb5Aq-0004dZ-2A
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 02:56:44 -0500
Received: by mail-ea0-f173.google.com with SMTP id i13so2837275eaa.4
	for <qemu-devel@nongnu.org>; Tue, 20 Nov 2012 23:56:43 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <50AC8938.9030708@redhat.com>
Date: Wed, 21 Nov 2012 08:56:40 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1353404767-4495-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1353404767-4495-5-git-send-email-xiawenc@linux.vnet.ibm.com>
	<50AB5AF0.8010701@redhat.com> <50AC4467.4050101@linux.vnet.ibm.com>
In-Reply-To: <50AC4467.4050101@linux.vnet.ibm.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, kraxel@redhat.com

Il 21/11/2012 04:03, Wenchao Xia ha scritto:
>>
>>> +libqblock="yes"
>>
>> Please make the default the empty string, i.e. "build if and only if
>> libtool is present".
>>
>   Do you mean adding a probe section later that if libtool is present,
> its default is "yes", else set it to "no"?

Here, you just do libqblock="".

Then --enable-libqblock and --disable-libqblock set it to yes or no.

Then, if $libqblock = yes, and no libtool, fail.

If $libqblock is empty, and no libtool, set it to no.

If $libqblock is empty, and libtool is there, set it to yes.

Paolo