From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb8DG-0000v0-PJ for qemu-devel@nongnu.org; Wed, 21 Nov 2012 06:11:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tb8D9-0003Cb-TT for qemu-devel@nongnu.org; Wed, 21 Nov 2012 06:11:26 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:47101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb8D9-0003CT-LA for qemu-devel@nongnu.org; Wed, 21 Nov 2012 06:11:19 -0500 Received: from /spool/local by e06smtp17.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Nov 2012 11:11:16 -0000 Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qALBB7BY61276340 for ; Wed, 21 Nov 2012 11:11:07 GMT Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qALBBEAS010242 for ; Wed, 21 Nov 2012 04:11:14 -0700 Message-ID: <50ACB6D0.5060401@de.ibm.com> Date: Wed, 21 Nov 2012 12:11:12 +0100 From: Christian Borntraeger MIME-Version: 1.0 References: <1353421834-44687-1-git-send-email-borntraeger@de.ibm.com> <50AB9887.40908@suse.de> In-Reply-To: <50AB9887.40908@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Kevin Wolf , Peter Maydell , Anthony Liguori , Igor Mitsyanko , qemu-devel , Markus Armbruster , Jens Freimann , Stefan Hajnoczi , Cornelia Huck , Andreas Faerber , Einar Lueck On 20/11/12 15:49, Alexander Graf wrote: > On 11/20/2012 03:30 PM, Christian Borntraeger wrote: >> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a >> default/standard interface to their block devices / drives. Therefore, >> this patch introduces a new field default_block_type per QEMUMachine >> struct. The prior use_scsi field becomes thereby obsolete and is >> replaced through .default_block_type = IF_SCSI. >> >> This patch also changes the default for s390x to IF_VIRTIO and >> removes an early hack that converts IF_IDE drives. >> Other parties have already claimed interest (e.g. IF_SD for exynos) >> >> To create a sane default, for machines that dont specify a >> default_block_type, this patch makes IF_IDE = 0 and IF_NONE = 1. >> I checked all users of IF_NONE (blockdev.c and ww/device-hotplug.c) >> as well as IF_IDE and it seems that it is ok to change the defines - >> in other words, I found no obvious (to me) assumption in the code >> regarding IF_NONE==0. IF_NONE is only set if there is an >> explicit if=none. Without if=* the interface becomes IF_DEFAULT. >> >> I would suggest to have some additional care, e.g. by letting >> this patch sit some days in the block tree. >> >> Based on an initial patch from Einar Lueck >> >> Signed-off-by: Christian Borntraeger >> CC: Igor Mitsyanko >> CC: Markus Armbruster >> CC: Kevin Wolf > > Reviewed-by: Alexander Graf > > However, I would consider this 1.4 material :). Agreed. Kevin, Stefan, any chance to queue that up in your tree for 1.4? Christian