* [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument
@ 2012-11-20 14:11 Bruce Rogers
2012-11-20 15:14 ` Markus Armbruster
2012-11-23 6:49 ` [Qemu-devel] [PATCH 1.3] " Stefan Hajnoczi
0 siblings, 2 replies; 7+ messages in thread
From: Bruce Rogers @ 2012-11-20 14:11 UTC (permalink / raw)
To: qemu-devel; +Cc: Bruce Rogers
The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
should be marked as having no argument.
Signed-off-by: Bruce Rogers <brogers@suse.com>
---
qemu-options.hx | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 9bb29d3..fbcf079 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
ETEXI
HXCOMM Deprecated by -machine accel=tcg property
-DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
+DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
HXCOMM Deprecated by kvm-pit driver properties
-DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
+DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
"", QEMU_ARCH_I386)
HXCOMM Deprecated (ignored)
-DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
+DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
HXCOMM Deprecated by -machine kernel_irqchip=on|off property
-DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
+DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
HXCOMM Deprecated (ignored)
DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
--
1.7.7
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument
2012-11-20 14:11 [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument Bruce Rogers
@ 2012-11-20 15:14 ` Markus Armbruster
2012-11-21 12:12 ` Jan Kiszka
2012-11-23 6:49 ` [Qemu-devel] [PATCH 1.3] " Stefan Hajnoczi
1 sibling, 1 reply; 7+ messages in thread
From: Markus Armbruster @ 2012-11-20 15:14 UTC (permalink / raw)
To: Bruce Rogers; +Cc: jan.kiszka, Marcelo Tosatti, qemu-devel
Cc'ing Marcelo & Jan to speed up patch application.
Bruce Rogers <brogers@suse.com> writes:
> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> should be marked as having no argument.
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> qemu-options.hx | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9bb29d3..fbcf079 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
> ETEXI
>
> HXCOMM Deprecated by -machine accel=tcg property
> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated by kvm-pit driver properties
> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
> "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated (ignored)
> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated by -machine kernel_irqchip=on|off property
> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated (ignored)
> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument
2012-11-20 15:14 ` Markus Armbruster
@ 2012-11-21 12:12 ` Jan Kiszka
2012-11-22 12:34 ` Luiz Capitulino
0 siblings, 1 reply; 7+ messages in thread
From: Jan Kiszka @ 2012-11-21 12:12 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Marcelo Tosatti, qemu-devel@nongnu.org, Bruce Rogers
On 2012-11-20 16:14, Markus Armbruster wrote:
> Cc'ing Marcelo & Jan to speed up patch application.
>
> Bruce Rogers <brogers@suse.com> writes:
>
>> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
>> should be marked as having no argument.
>>
>> Signed-off-by: Bruce Rogers <brogers@suse.com>
>> ---
>> qemu-options.hx | 8 ++++----
>> 1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/qemu-options.hx b/qemu-options.hx
>> index 9bb29d3..fbcf079 100644
>> --- a/qemu-options.hx
>> +++ b/qemu-options.hx
>> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
>> ETEXI
>>
>> HXCOMM Deprecated by -machine accel=tcg property
>> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
>> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
>>
>> HXCOMM Deprecated by kvm-pit driver properties
>> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
>> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
>> "", QEMU_ARCH_I386)
>>
>> HXCOMM Deprecated (ignored)
>> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
>> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
>>
>> HXCOMM Deprecated by -machine kernel_irqchip=on|off property
>> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>>
>> HXCOMM Deprecated (ignored)
>> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
--
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument
2012-11-21 12:12 ` Jan Kiszka
@ 2012-11-22 12:34 ` Luiz Capitulino
2012-11-23 6:50 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 1 reply; 7+ messages in thread
From: Luiz Capitulino @ 2012-11-22 12:34 UTC (permalink / raw)
To: Jan Kiszka
Cc: qemu-trivial, Bruce Rogers, Marcelo Tosatti, Markus Armbruster,
qemu-devel@nongnu.org
On Wed, 21 Nov 2012 13:12:53 +0100
Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2012-11-20 16:14, Markus Armbruster wrote:
> > Cc'ing Marcelo & Jan to speed up patch application.
> >
> > Bruce Rogers <brogers@suse.com> writes:
> >
> >> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> >> should be marked as having no argument.
> >>
> >> Signed-off-by: Bruce Rogers <brogers@suse.com>
> >> ---
> >> qemu-options.hx | 8 ++++----
> >> 1 files changed, 4 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/qemu-options.hx b/qemu-options.hx
> >> index 9bb29d3..fbcf079 100644
> >> --- a/qemu-options.hx
> >> +++ b/qemu-options.hx
> >> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
> >> ETEXI
> >>
> >> HXCOMM Deprecated by -machine accel=tcg property
> >> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> >> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> >>
> >> HXCOMM Deprecated by kvm-pit driver properties
> >> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
> >> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
> >> "", QEMU_ARCH_I386)
> >>
> >> HXCOMM Deprecated (ignored)
> >> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> >> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> >>
> >> HXCOMM Deprecated by -machine kernel_irqchip=on|off property
> >> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> >> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> >>
> >> HXCOMM Deprecated (ignored)
> >> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
>
> Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Candidate for -trivial.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH 1.3] Legacy qemu-kvm options have no argument
2012-11-20 14:11 [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument Bruce Rogers
2012-11-20 15:14 ` Markus Armbruster
@ 2012-11-23 6:49 ` Stefan Hajnoczi
1 sibling, 0 replies; 7+ messages in thread
From: Stefan Hajnoczi @ 2012-11-23 6:49 UTC (permalink / raw)
To: anthony; +Cc: Luiz Capitulino, qemu-devel, Bruce Rogers
On Tue, Nov 20, 2012 at 07:11:21AM -0700, Bruce Rogers wrote:
> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> should be marked as having no argument.
>
> Signed-off-by: Bruce Rogers <brogers@suse.com>
> ---
> qemu-options.hx | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 9bb29d3..fbcf079 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
> ETEXI
>
> HXCOMM Deprecated by -machine accel=tcg property
> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated by kvm-pit driver properties
> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
> "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated (ignored)
> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated by -machine kernel_irqchip=on|off property
> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
>
> HXCOMM Deprecated (ignored)
> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
> --
> 1.7.7
Anthony, please consider this patch for QEMU 1.3-rc1. Without it the
deprecated qemu-kvm options don't work!
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] Legacy qemu-kvm options have no argument
2012-11-22 12:34 ` Luiz Capitulino
@ 2012-11-23 6:50 ` Stefan Hajnoczi
2012-11-23 11:48 ` Luiz Capitulino
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Hajnoczi @ 2012-11-23 6:50 UTC (permalink / raw)
To: Luiz Capitulino
Cc: qemu-trivial, Jan Kiszka, Marcelo Tosatti, qemu-devel@nongnu.org,
Markus Armbruster, Bruce Rogers
On Thu, Nov 22, 2012 at 10:34:11AM -0200, Luiz Capitulino wrote:
> On Wed, 21 Nov 2012 13:12:53 +0100
> Jan Kiszka <jan.kiszka@siemens.com> wrote:
>
> > On 2012-11-20 16:14, Markus Armbruster wrote:
> > > Cc'ing Marcelo & Jan to speed up patch application.
> > >
> > > Bruce Rogers <brogers@suse.com> writes:
> > >
> > >> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> > >> should be marked as having no argument.
> > >>
> > >> Signed-off-by: Bruce Rogers <brogers@suse.com>
> > >> ---
> > >> qemu-options.hx | 8 ++++----
> > >> 1 files changed, 4 insertions(+), 4 deletions(-)
> > >>
> > >> diff --git a/qemu-options.hx b/qemu-options.hx
> > >> index 9bb29d3..fbcf079 100644
> > >> --- a/qemu-options.hx
> > >> +++ b/qemu-options.hx
> > >> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
> > >> ETEXI
> > >>
> > >> HXCOMM Deprecated by -machine accel=tcg property
> > >> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> > >> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> > >>
> > >> HXCOMM Deprecated by kvm-pit driver properties
> > >> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
> > >> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
> > >> "", QEMU_ARCH_I386)
> > >>
> > >> HXCOMM Deprecated (ignored)
> > >> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> > >> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> > >>
> > >> HXCOMM Deprecated by -machine kernel_irqchip=on|off property
> > >> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> > >> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> > >>
> > >> HXCOMM Deprecated (ignored)
> > >> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
> >
> > Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Candidate for -trivial.
This is more urgent than trivial. It is necessary for qemu-kvm
compatibility and I think should go into QEMU 1.3. Otherwise we have to
wait until QEMU 1.4 to complete the qemu-kvm -> qemu transition.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] Legacy qemu-kvm options have no argument
2012-11-23 6:50 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
@ 2012-11-23 11:48 ` Luiz Capitulino
0 siblings, 0 replies; 7+ messages in thread
From: Luiz Capitulino @ 2012-11-23 11:48 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-trivial, Jan Kiszka, Marcelo Tosatti, qemu-devel@nongnu.org,
Markus Armbruster, Bruce Rogers
On Fri, 23 Nov 2012 07:50:49 +0100
Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Thu, Nov 22, 2012 at 10:34:11AM -0200, Luiz Capitulino wrote:
> > On Wed, 21 Nov 2012 13:12:53 +0100
> > Jan Kiszka <jan.kiszka@siemens.com> wrote:
> >
> > > On 2012-11-20 16:14, Markus Armbruster wrote:
> > > > Cc'ing Marcelo & Jan to speed up patch application.
> > > >
> > > > Bruce Rogers <brogers@suse.com> writes:
> > > >
> > > >> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip
> > > >> should be marked as having no argument.
> > > >>
> > > >> Signed-off-by: Bruce Rogers <brogers@suse.com>
> > > >> ---
> > > >> qemu-options.hx | 8 ++++----
> > > >> 1 files changed, 4 insertions(+), 4 deletions(-)
> > > >>
> > > >> diff --git a/qemu-options.hx b/qemu-options.hx
> > > >> index 9bb29d3..fbcf079 100644
> > > >> --- a/qemu-options.hx
> > > >> +++ b/qemu-options.hx
> > > >> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode.
> > > >> ETEXI
> > > >>
> > > >> HXCOMM Deprecated by -machine accel=tcg property
> > > >> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> > > >> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386)
> > > >>
> > > >> HXCOMM Deprecated by kvm-pit driver properties
> > > >> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection,
> > > >> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection,
> > > >> "", QEMU_ARCH_I386)
> > > >>
> > > >> HXCOMM Deprecated (ignored)
> > > >> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> > > >> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386)
> > > >>
> > > >> HXCOMM Deprecated by -machine kernel_irqchip=on|off property
> > > >> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> > > >> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386)
> > > >>
> > > >> HXCOMM Deprecated (ignored)
> > > >> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL)
> > >
> > > Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
> >
> > Candidate for -trivial.
>
> This is more urgent than trivial. It is necessary for qemu-kvm
> compatibility and I think should go into QEMU 1.3. Otherwise we have to
> wait until QEMU 1.4 to complete the qemu-kvm -> qemu transition.
That's true, I missed the fact that you don't do pull requests during
hard freeze...
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-11-23 11:48 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-20 14:11 [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument Bruce Rogers
2012-11-20 15:14 ` Markus Armbruster
2012-11-21 12:12 ` Jan Kiszka
2012-11-22 12:34 ` Luiz Capitulino
2012-11-23 6:50 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-11-23 11:48 ` Luiz Capitulino
2012-11-23 6:49 ` [Qemu-devel] [PATCH 1.3] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).