From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb9At-0007Ao-3a for qemu-devel@nongnu.org; Wed, 21 Nov 2012 07:13:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tb9Aq-0005gR-92 for qemu-devel@nongnu.org; Wed, 21 Nov 2012 07:13:03 -0500 Received: from david.siemens.de ([192.35.17.14]:21530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb9Ap-0005gE-Vi for qemu-devel@nongnu.org; Wed, 21 Nov 2012 07:13:00 -0500 Message-ID: <50ACC545.7000002@siemens.com> Date: Wed, 21 Nov 2012 13:12:53 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1353420681-8870-1-git-send-email-brogers@suse.com> <87lidwux0q.fsf@blackfin.pond.sub.org> In-Reply-To: <87lidwux0q.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Legacy qemu-kvm options have no argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Marcelo Tosatti , "qemu-devel@nongnu.org" , Bruce Rogers On 2012-11-20 16:14, Markus Armbruster wrote: > Cc'ing Marcelo & Jan to speed up patch application. > > Bruce Rogers writes: > >> The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqchip >> should be marked as having no argument. >> >> Signed-off-by: Bruce Rogers >> --- >> qemu-options.hx | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/qemu-options.hx b/qemu-options.hx >> index 9bb29d3..fbcf079 100644 >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode. >> ETEXI >> >> HXCOMM Deprecated by -machine accel=tcg property >> -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) >> +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) >> >> HXCOMM Deprecated by kvm-pit driver properties >> -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinjection, >> +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection, >> "", QEMU_ARCH_I386) >> >> HXCOMM Deprecated (ignored) >> -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386) >> +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386) >> >> HXCOMM Deprecated by -machine kernel_irqchip=on|off property >> -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386) >> +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I386) >> >> HXCOMM Deprecated (ignored) >> DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL) Reviewed-by: Jan Kiszka -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux