From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41129)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Tb9XR-00054b-LT
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 07:36:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Tb9XL-0004Fv-EM
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 07:36:21 -0500
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:49255)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Tb9XL-0004Fo-5m
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 07:36:15 -0500
Received: from /spool/local
	by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Wed, 21 Nov 2012 12:36:12 -0000
Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com
	[9.149.37.213])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id qALCa1Dv52166828
	for <qemu-devel@nongnu.org>; Wed, 21 Nov 2012 12:36:01 GMT
Received: from d06av03.portsmouth.uk.ibm.com (localhost.localdomain
	[127.0.0.1])
	by d06av03.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id qALCa0H3018823
	for <qemu-devel@nongnu.org>; Wed, 21 Nov 2012 05:36:01 -0700
Message-ID: <50ACCAAF.3030708@de.ibm.com>
Date: Wed, 21 Nov 2012 13:35:59 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1353421834-44687-1-git-send-email-borntraeger@de.ibm.com>
	<50ACC41F.8080403@samsung.com>
In-Reply-To: <50ACC41F.8080403@samsung.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3] Support default block interfaces per
	QEMUMachine
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: i.mitsyanko@samsung.com
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Markus Armbruster <armbru@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Jens Freimann <jfrei@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Kyungmin Park <kyungmin.park@samsung.com>, Andreas Faerber <afaerber@suse.de>, Einar Lueck <elelueck@de.ibm.com>

On 21/11/12 13:07, Igor Mitsyanko wrote:
> This version of patch doesn't change anything for majority of machines, its just that later we can
> choose ourself which default block interface to use. So, nothing to review from Exynos point of view, but patch
> is OK, except realview_pb_a8 part (see bellow):
> 
> Acked-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
> 
> 
> On 11/20/2012 06:30 PM, Christian Borntraeger wrote:
> 
>>   @@ -379,13 +379,14 @@ static QEMUMachine realview_pb_a8_machine = {
>>       .name = "realview-pb-a8",
>>       .desc = "ARM RealView Platform Baseboard for Cortex-A8",
>>       .init = realview_pb_a8_init,
>> +    .block_default_type = IF_SCSI,
>>   };
>>   
> 
> 
> I think that's an unintentional change?

Indeed.

Kevin, Stefan, in case of no other findings, can you fix that hunk yourself or do
you want a new patch?

Christian