From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Weil <weil@mail.berlios.de>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers
Date: Wed, 21 Nov 2012 15:08:16 +0100 [thread overview]
Message-ID: <50ACE050.8050001@redhat.com> (raw)
In-Reply-To: <50ACDE8F.5010507@siemens.com>
Il 21/11/2012 15:00, Jan Kiszka ha scritto:
> + if (!TlsGetValue(current_tls_index)) {
> + leader = g_malloc0(sizeof(*leader));
> + leader->fiber = ConvertThreadToFiber(NULL);
> + TlsSetValue(current_tls_index, &leader->base);
> }
Leaking leader is a bit bad, but it looks ok for 1.3.
For 1.4 we really should bring back a portable solution for TLS that
includes statically-allocated data.
Paolo
next prev parent reply other threads:[~2012-11-21 14:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 14:00 [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers Jan Kiszka
2012-11-21 14:08 ` Paolo Bonzini [this message]
2012-11-21 14:29 ` Jan Kiszka
2012-11-21 14:33 ` malc
2012-11-21 14:38 ` Paolo Bonzini
2012-11-21 14:49 ` Jan Kiszka
2012-11-21 15:44 ` Jan Kiszka
2012-11-21 15:54 ` Paolo Bonzini
2012-11-21 16:00 ` Jan Kiszka
2012-11-21 19:11 ` Stefan Weil
2012-11-22 8:59 ` Paolo Bonzini
2012-11-22 12:07 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ACE050.8050001@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).