From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Stefan Priebe <s.priebe@profhost.ag>
Subject: Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel
Date: Wed, 21 Nov 2012 16:34:25 +0100 [thread overview]
Message-ID: <50ACF481.3020103@redhat.com> (raw)
In-Reply-To: <50AC9C85.6070803@profihost.ag>
Il 21/11/2012 10:19, Stefan Priebe - Profihost AG ha scritto:
> Hello Stefan,
> hello Paolo,
>
> most of the ideas and removing the whole cancellation stuff came from
> Paolo. Maybe he can comment also?
I agree with all of Stefan's comments. This includes putting back
acb->cancelled---but this time done right: note that
qemu_rbd_complete_aio was always releasing the AIOCB
if (acb->cancelled) {
qemu_vfree(acb->bounce);
qemu_aio_release(acb);
goto done;
}
and according to Stefan's review it shouldn't.
Paolo
next prev parent reply other threads:[~2012-11-21 15:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 20:39 [Qemu-devel] (no subject) Stefan Priebe
2012-11-19 20:39 ` [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel Stefan Priebe
2012-11-21 8:56 ` Josh Durgin
2012-11-21 9:07 ` Stefan Hajnoczi
2012-11-21 9:19 ` Stefan Priebe - Profihost AG
2012-11-21 15:34 ` Paolo Bonzini [this message]
2012-11-22 10:01 ` Stefan Priebe - Profihost AG
-- strict thread matches above, loose matches on Subject: below --
2012-11-22 10:00 Stefan Priebe
2012-11-24 19:54 ` Blue Swirl
2012-11-24 20:21 ` Stefan Priebe
2012-11-27 22:42 ` Josh Durgin
2012-11-29 15:24 ` Paolo Bonzini
2012-11-29 13:58 ` Stefan Hajnoczi
2012-11-29 14:32 ` Stefan Priebe - Profihost AG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ACF481.3020103@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=s.priebe@profhost.ag \
--cc=s.priebe@profihost.ag \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).