From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbCJt-0001DU-Sj for qemu-devel@nongnu.org; Wed, 21 Nov 2012 10:34:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbCJs-0000mG-UR for qemu-devel@nongnu.org; Wed, 21 Nov 2012 10:34:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:11888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbCJs-0000l0-MI for qemu-devel@nongnu.org; Wed, 21 Nov 2012 10:34:32 -0500 Message-ID: <50ACF481.3020103@redhat.com> Date: Wed, 21 Nov 2012 16:34:25 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1353357585-31746-1-git-send-email-s.priebe@profihost.ag> <1353357585-31746-2-git-send-email-s.priebe@profihost.ag> <20121121090751.GC17466@stefanha-thinkpad.redhat.com> <50AC9C85.6070803@profihost.ag> In-Reply-To: <50AC9C85.6070803@profihost.ag> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rbd block driver fix race between aio completition and aio cancel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Priebe - Profihost AG Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, Stefan Priebe Il 21/11/2012 10:19, Stefan Priebe - Profihost AG ha scritto: > Hello Stefan, > hello Paolo, > > most of the ideas and removing the whole cancellation stuff came from > Paolo. Maybe he can comment also? I agree with all of Stefan's comments. This includes putting back acb->cancelled---but this time done right: note that qemu_rbd_complete_aio was always releasing the AIOCB if (acb->cancelled) { qemu_vfree(acb->bounce); qemu_aio_release(acb); goto done; } and according to Stefan's review it shouldn't. Paolo