From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37056)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1TbCyY-0001be-H2
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 11:16:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1TbCyR-0006Ow-AP
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 11:16:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:1506)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1TbCyR-0006Or-2N
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 11:16:27 -0500
Message-ID: <50ACFE58.8000606@redhat.com>
Date: Wed, 21 Nov 2012 09:16:24 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1353488464-82756-1-git-send-email-dietmar@proxmox.com>
	<1353488464-82756-4-git-send-email-dietmar@proxmox.com>
In-Reply-To: <1353488464-82756-4-git-send-email-dietmar@proxmox.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="------------enigD422B220BDDDD4595225ACA0"
Subject: Re: [Qemu-devel] [PATCH 4/5] add backup related monitor commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dietmar Maurer <dietmar@proxmox.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigD422B220BDDDD4595225ACA0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 11/21/2012 02:01 AM, Dietmar Maurer wrote:
> We currently create 'vma' archives without any configuration inside.
> Future versions may support other formats...
>=20
> Another option would be to simply dump <devid,cluster_num,cluster_data>=
 to
> the output fh (pipe), and an external binary saves the data. That way w=
e
> could move the whole archive format related code out of qemu.
>=20

> +++ b/qapi-schema.json
> @@ -357,6 +357,13 @@
>  ##
>  { 'type': 'EventInfo', 'data': {'name': 'str'} }
> =20
> +
> +{ 'type': 'BackupStatus',
> +  'data': {'*status': 'str', '*errmsg': 'str', '*total': 'int',
> +           '*transferred': 'int', '*zero-bytes': 'int',
> +           '*start-time': 'int', '*end-time': 'int',
> +           '*backupfile': 'str', '*uuid': 'str' } }
> +

Missing documentation for what all these fields mean.

>  ##
>  # @query-events:
>  #
> @@ -1764,6 +1771,45 @@
>    'data': { 'path': 'str' },
>    'returns': [ 'ObjectPropertyInfo' ] }
> =20
> +
> +##
> +# @backup:
> +#
> +# Starts a VM backup.
> +#
> +# @backupfile: the backup file name
> +#
> +# @speed:  #optional the maximum speed, in bytes per second
> +#
> +# Returns: the uuid of the backup job
> +#

Needs to mention when it was introduced (at best, it will be since 1.4).

> +##
> +{ 'command': 'backup', 'data': { 'backupfile': 'str', '*devlist': 'str=
',
> +                                 '*speed': 'int' },
> +  'returns': 'str' }
> +
> +##
> +# @query-backup
> +#
> +# Returns information about current/last backup task.
> +#
> +# Returns: @BackupStatus
> +#
> +##
> +{ 'command': 'query-backup', 'returns': 'BackupStatus' }
> +
> +##
> +# @backup_cancel

s/_/-/, you should prefer dashes in QMP

> +#
> +# Cancel the current executing backup process.
> +#
> +# Returns: nothing on success
> +#
> +# Notes: This command succeeds even if there is no backup process runn=
ing.
> +#
> +##
> +{ 'command': 'backup_cancel' }
> +

You are basically adding a new asynchronous job.  Do you really need to
add a 'backup-cancel' command, or should we be reusing a generic
framework for canceling arbitrary jobs?

--=20
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--------------enigD422B220BDDDD4595225ACA0
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with undefined - http://www.enigmail.net/

iQEcBAEBCAAGBQJQrP5YAAoJEKeha0olJ0NqW5wIAJ7NDch8KnFFsNtIMkCVb+JA
Mb9IXM7WgvZZ0D1CE/siKTRnhGnfwcaokA0muqAjMG2anbs1fTWsW05NOCj8EEmk
xu22rFIwXcLhOLTzV0wzV2Z1KDNZVDltidrY5sp+qkDa64FPM7zOarGHzO8jVOVP
StEsLowDTtu2sm9OsrUImO09sxf3ieAOtI4YedZRKgvT6aPX4XtF5KGsajXsmacd
4zuMMZ0mqVE9zdoHXQAZDtJ8Z02dWDuqTF2bYAhfRf9gJ+D1X85zZpz7ZNIedXPD
yqDCw6cmeIzGlJIe+MeA1yywsWR1yHPu7MrlI1t6b+R3wOPNmkXCDs49n8fJNgw=
=54om
-----END PGP SIGNATURE-----

--------------enigD422B220BDDDD4595225ACA0--