qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Paolo Bonzini <pbonzini@redhat.com>, Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Weil <weil@mail.berlios.de>,
	qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers
Date: Wed, 21 Nov 2012 20:11:54 +0100	[thread overview]
Message-ID: <50AD277A.8000904@weilnetz.de> (raw)
In-Reply-To: <50ACE764.1070608@redhat.com>

Am 21.11.2012 15:38, schrieb Paolo Bonzini:
> Il 21/11/2012 15:33, malc ha scritto:
>>>>>> Leaking leader is a bit bad, but it looks ok for 1.3.
>>>> Hmm. A TLS destructor is apparently not available. Is there some "on
>>>> thread termination" callback mechanism on Windows? Didn't find one on
>>>> first glance.
>>>>
>> Dlls receive something like THREAD_DETTACH in it's startup routine or
>> something like that if my memory serves me.
> Only DLLs.
>
> But this sounds like deja-vu.  I'm pretty sure in the past we just
> decided that this compiler is not supported (of course it's bad that
> it's silent).  Stefan, do you remember the details?
>
> Paolo

Debian cross works with -mthread.The issue was discussed here:

https://bugs.launchpad.net/qemu/+bug/932487

Jan, I don't think your patch should be applied.

Current MinGW / MinGW-w64 compilers work, so those users
which compile and use QEMU on Windows won't have a problem.
With MinGW-w64, it is even possible to compile QEMU with nearly
no warnings :-)

Debian cross development is full of difficulties. Passing an extra
compiler option like -mthread is only one of these difficulties.
I updated http://wiki.qemu.org/Hosts/W32, so anybody who really
wants to run cross compilations on Debian can get more information
there.

We could add a check to configure and add -mthread automatically.
Up to now, there was no consensus whether this is wanted because
-mthread adds a library to QEMU's dependencies.

Stefan

  parent reply	other threads:[~2012-11-21 19:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21 14:00 [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers Jan Kiszka
2012-11-21 14:08 ` Paolo Bonzini
2012-11-21 14:29   ` Jan Kiszka
2012-11-21 14:33     ` malc
2012-11-21 14:38       ` Paolo Bonzini
2012-11-21 14:49         ` Jan Kiszka
2012-11-21 15:44           ` Jan Kiszka
2012-11-21 15:54             ` Paolo Bonzini
2012-11-21 16:00               ` Jan Kiszka
2012-11-21 19:11         ` Stefan Weil [this message]
2012-11-22  8:59           ` Paolo Bonzini
2012-11-22 12:07           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AD277A.8000904@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=jan.kiszka@siemens.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=weil@mail.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).