From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbLti-0005j2-S6 for qemu-devel@nongnu.org; Wed, 21 Nov 2012 20:48:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbLth-00085e-R6 for qemu-devel@nongnu.org; Wed, 21 Nov 2012 20:48:10 -0500 Received: from e28smtp06.in.ibm.com ([122.248.162.6]:39983) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbLth-000857-7c for qemu-devel@nongnu.org; Wed, 21 Nov 2012 20:48:09 -0500 Received: from /spool/local by e28smtp06.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Nov 2012 07:17:50 +0530 Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67]) by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qAM1lkiB25559262 for ; Thu, 22 Nov 2012 07:17:47 +0530 Received: from d28av05.in.ibm.com (loopback [127.0.0.1]) by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qAM7HRrD024957 for ; Thu, 22 Nov 2012 18:17:27 +1100 Message-ID: <50AD8428.4070801@linux.vnet.ibm.com> Date: Thu, 22 Nov 2012 09:47:20 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1353404767-4495-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1353404767-4495-5-git-send-email-xiawenc@linux.vnet.ibm.com> <50AB5AF0.8010701@redhat.com> <50AC4467.4050101@linux.vnet.ibm.com> <50AC8938.9030708@redhat.com> In-Reply-To: <50AC8938.9030708@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V10 4/7] libqblock build system List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, kraxel@redhat.com 于 2012-11-21 15:56, Paolo Bonzini 写道: > Il 21/11/2012 04:03, Wenchao Xia ha scritto: >>> >>>> +libqblock="yes" >>> >>> Please make the default the empty string, i.e. "build if and only if >>> libtool is present". >>> >> Do you mean adding a probe section later that if libtool is present, >> its default is "yes", else set it to "no"? > > Here, you just do libqblock="". > > Then --enable-libqblock and --disable-libqblock set it to yes or no. > > Then, if $libqblock = yes, and no libtool, fail. > > If $libqblock is empty, and no libtool, set it to no. > > If $libqblock is empty, and libtool is there, set it to yes. > > Paolo > got it, will change it as comments. -- Best Regards Wenchao Xia