From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbLwW-0008R3-IE for qemu-devel@nongnu.org; Wed, 21 Nov 2012 20:51:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbLwV-0000tF-C2 for qemu-devel@nongnu.org; Wed, 21 Nov 2012 20:51:04 -0500 Received: from e23smtp01.au.ibm.com ([202.81.31.143]:42608) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbLwU-0000rE-Qc for qemu-devel@nongnu.org; Wed, 21 Nov 2012 20:51:03 -0500 Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 22 Nov 2012 11:47:41 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id qAM1ot0D65274034 for ; Thu, 22 Nov 2012 12:50:55 +1100 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id qAM1osnl028614 for ; Thu, 22 Nov 2012 12:50:54 +1100 Message-ID: <50AD84F9.7010402@linux.vnet.ibm.com> Date: Thu, 22 Nov 2012 09:50:49 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1353404767-4495-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1353404767-4495-2-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V10 1/7] Buildsystem fix distclean error for pixman List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, kraxel@redhat.com, pbonzini@redhat.com 于 2012-11-22 6:54, Peter Maydell 写道: > On 20 November 2012 09:46, Wenchao Xia wrote: >> Currently Makefile test if pixman have configure log, but the script directly >> return error if that file do not exist. This patch fix it. >> >> v2: print out the command. > > We need this patch in 1.3 because otherwise 'distclean' barfs > if you're using internal pixman. This would be clearer if it > was a separate patch and not part of this libqblock series > (which is not for 1.3 as far as I know). > >> Signed-off-by: Wenchao Xia > > Reviewed-by: Peter Maydell > > thanks > -- PMM > >> --- >> Makefile | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/Makefile b/Makefile >> index 3e8d441..9ecbcbb 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -286,7 +286,7 @@ distclean: clean >> for d in $(TARGET_DIRS) $(QEMULIBS); do \ >> rm -rf $$d || exit 1 ; \ >> done >> - test -f pixman/config.log && make -C pixman distclean >> + if test -f pixman/config.log; then make -C pixman distclean; fi >> >> KEYMAPS=da en-gb et fr fr-ch is lt modifiers no pt-br sv \ >> ar de en-us fi fr-be hr it lv nl pl ru th \ >> -- >> 1.7.1 >> > will sent a separate patch, thanks. -- Best Regards Wenchao Xia