Re: [Qemu-devel] [PATCH v4 00/14] Add Q35 base support

[Gerd Hoffmann <kraxel@redhat.com>]

On 11/14/12 21:53, Jason Baron wrote:
> Hi,
> 
> These patches are intened to give us a base set of patches for Q35 upon which
> to build. The major change in this series is to add the memory controller hub,
> or 'mch' as proper member of the q35 host structure. This change refactors the
> code a bit, and moves more intialization out of pc_q35.c and into q35.c. We
> probably could go further and introduce a generic north bridge class and make
> the 'mch' a child of it, but I'm not proposing that kind of change this late in
> the development cycle.

Tested the patches while hacking on q35 seabios support last days.

> I've also dropped as many non-essential bits as possible, such as if=ahci from
> the patch series. Patches 13-14 allow the use of the '-L' option to specify
> the directory of the q35 dsdt table. These aren't strictly necessary. As one
> could pass:
> 
> -bios /root/seabios/seabios/out/bios.bin
> -acpitable file=/root/seabios/seabios/out/q35-acpi-dsdt.aml
> 
> But its rather cumbersome, and including the automatic load of the dsdt table,
> is the future direction. That is, once the seabios bits are included we can
> pull the q35 dsdt table into the qemu tree, and avoid extra options altogether.

I'd prefer to not include patches 13+14.

Patch 13 is not needed long-term for q35, it is just a temporary testing
convinience.  Having a search path instead of a single directory might
be a useful feature independent of q35 support, but I think for this we
should simply allow to explicitly specify a search path, i.e. something
like -L "/path/to/dir/one:/path/to/dir/two".

Patch 14 should wait until we've merged seabios with q35 support.  It
also needs to be fixed to allow overriding the acpi table via command
line, i.e. only automatically load the default dsdt in case no dsdt was
specified via -acpitable.

Patches 1-12 are fine (and they still apply to master).

cheers,
  Gerd